]> Git Repo - linux.git/commit
sb_edac: Fix detection on SNB machines
authorBorislav Petkov <[email protected]>
Thu, 5 Feb 2015 11:39:36 +0000 (12:39 +0100)
committerBorislav Petkov <[email protected]>
Mon, 9 Feb 2015 15:55:26 +0000 (16:55 +0100)
commit11249e73992981e31fd50e7231da24fad68e3320
treec3434510df54479a64105d9f76f3b98f0ecc1f70
parentbfa76d49576599a4b9f9b7a71f23d73d6dcff735
sb_edac: Fix detection on SNB machines

d0585cd815fa ("sb_edac: Claim a different PCI device") changed the
probing of sb_edac to look for PCI device 0x3ca0:

3f:0e.0 System peripheral: Intel Corporation Xeon E5/Core i7 Processor Home Agent (rev 07)
00: 86 80 a0 3c 00 00 00 00 07 00 80 08 00 00 80 00
...

but we're matching for 0x3ca8, i.e. PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA
in sbridge_probe() therefore the probing fails.

Changing it to probe for 0x3ca0 (PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_HA0),
.i.e., the 14.0 device, fixes the issue and driver loads successfully
again:

[ 2449.013120] EDAC DEBUG: sbridge_init:
[ 2449.017029] EDAC sbridge: Seeking for: PCI ID 8086:3ca0
[ 2449.022368] EDAC DEBUG: sbridge_get_onedevice: Detected 8086:3ca0
[ 2449.028498] EDAC sbridge: Seeking for: PCI ID 8086:3ca0
[ 2449.033768] EDAC sbridge: Seeking for: PCI ID 8086:3ca8
[ 2449.039028] EDAC DEBUG: sbridge_get_onedevice: Detected 8086:3ca8
[ 2449.045155] EDAC sbridge: Seeking for: PCI ID 8086:3ca8
...

Add a debug printk while at it to be able to catch the failure in the
future and dump driver version on successful load.

Fixes: d0585cd815fa ("sb_edac: Claim a different PCI device")
Cc: [email protected] # 3.18
Acked-by: Aristeu Rozanski <[email protected]>
Cc: Tony Luck <[email protected]>
Acked-by: Andy Lutomirski <[email protected]>
Acked-by: Mauro Carvalho Chehab <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
drivers/edac/sb_edac.c
This page took 0.042309 seconds and 4 git commands to generate.