]> Git Repo - linux.git/commit
r8152: napi hangup fix after disconnect
authorJiri Slaby <[email protected]>
Mon, 25 Jun 2018 07:26:27 +0000 (09:26 +0200)
committerDavid S. Miller <[email protected]>
Tue, 26 Jun 2018 09:00:44 +0000 (18:00 +0900)
commit0ee1f4734967af8321ecebaf9c74221ace34f2d5
treee16cf27ce9c677b066ee8f618e5021965107eaca
parent6f0d349d922ba44e4348a17a78ea51b7135965b1
r8152: napi hangup fix after disconnect

When unplugging an r8152 adapter while the interface is UP, the NIC
becomes unusable.  usb->disconnect (aka rtl8152_disconnect) deletes
napi. Then, rtl8152_disconnect calls unregister_netdev and that invokes
netdev->ndo_stop (aka rtl8152_close). rtl8152_close tries to
napi_disable, but the napi is already deleted by disconnect above. So
the first while loop in napi_disable never finishes. This results in
complete deadlock of the network layer as there is rtnl_mutex held by
unregister_netdev.

So avoid the call to napi_disable in rtl8152_close when the device is
already gone.

The other calls to usb_kill_urb, cancel_delayed_work_sync,
netif_stop_queue etc. seem to be fine. The urb and netdev is not
destroyed yet.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: David S. Miller <[email protected]>
drivers/net/usb/r8152.c
This page took 0.055473 seconds and 4 git commands to generate.