]> Git Repo - linux.git/commit
drm: remove DRM_FORMAT_NV12MT
authorDaniel Vetter <[email protected]>
Tue, 3 Feb 2015 15:37:45 +0000 (16:37 +0100)
committerDaniel Vetter <[email protected]>
Wed, 4 Feb 2015 09:10:05 +0000 (10:10 +0100)
commit083500baefd5f4c215a5a93aef2492c1aa775828
treeeec6025946324361503f56aa42a71b3294822ddb
parentf79d1548b0fea94f2ccf089e49480da5202918bc
drm: remove DRM_FORMAT_NV12MT

So this has been merged originally in

commit 83052d4d5cd518332440bb4ee63d68bb5f744e0f
Author: Seung-Woo Kim <[email protected]>
Date:   Thu Dec 15 15:40:55 2011 +0900

    drm: Add multi buffer plane pixel formats

which hasn't seen a lot of review really. The problem is that it's not
a real pixel format, but just a different way to lay out NV12 pixels
in macroblocks, i.e. a tiling format.

The new way of doing this is with the soon-to-be-merged fb modifiers.

This was brough up in some long irc discussion around the entire
topic, as an example of where things have gone wrong. Luckily we can
correct the mistake:
- The kms side support for NV12MT is all dead code because
  format_check in drm_crtc.c never accepted NV12MT.
- The gem side for the gsc support doesn't look better: The code
  forgets to set the pixel format and makes a big mess with the tiling
  mode bits, inadvertedly setting them all.

Conclusion: This never really worked (at least not in upstream) and
hence we can safely correct our mistake here.

Cc: Seung-Woo Kim <[email protected]>
Cc: Inki Dae <[email protected]>
Cc: Kyungmin Park <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Daniel Stone <[email protected]>
Cc: Damien Lespiau <[email protected]>
Reviewed-by: Rob Clark <[email protected]>
Reviewed-by: Gustavo Padovan <[email protected]>
Acked-by: Joonyoung Shim <[email protected]>
Acked-by: Seung-Woo Kim <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_fimc.c
drivers/gpu/drm/exynos/exynos_drm_gsc.c
drivers/gpu/drm/exynos/exynos_drm_plane.c
drivers/gpu/drm/exynos/exynos_mixer.c
include/uapi/drm/drm_fourcc.h
This page took 0.088254 seconds and 4 git commands to generate.