]> Git Repo - linux.git/log
linux.git
5 years agoALSA: trident: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:36 +0000 (07:11 +0100)]
ALSA: trident: Drop superfluous ioctl PCM ops

snd_trident_ioctl() does nothing but calling the default handler.
Now PCM core accepts NULL as the default ioctl ops(*), so let's drop
altogether.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: asihpi: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:35 +0000 (07:11 +0100)]
ALSA: asihpi: Drop superfluous ioctl PCM ops

snd_card_asihpi_playback_ioctl() and snd_card_asihpi_capture_ioctl()
do nothing but calling the default handler.
Now PCM core accepts NULL as the default ioctl ops(*), so let's drop
altogether.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: atiixp: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:34 +0000 (07:11 +0100)]
ALSA: atiixp: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: via82xx: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:33 +0000 (07:11 +0100)]
ALSA: via82xx: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: intel8x0: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:32 +0000 (07:11 +0100)]
ALSA: intel8x0: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: parisc: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:31 +0000 (07:11 +0100)]
ALSA: parisc: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: mips: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:30 +0000 (07:11 +0100)]
ALSA: mips: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: isa: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:29 +0000 (07:11 +0100)]
ALSA: isa: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: es1688: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:28 +0000 (07:11 +0100)]
ALSA: es1688: Drop superfluous ioctl PCM ops

snd_es1688_ioctl() does nothing but calling the default handler.
Now PCM core accepts NULL as the default ioctl ops(*), so let's drop
altogether.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: firewire: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:27 +0000 (07:11 +0100)]
ALSA: firewire: Drop superfluous ioctl PCM ops

All the PCM ioctl ops of ALSA FireWire drivers do nothing but calling
the default handler.

Now PCM core accepts NULL as the default ioctl ops(*), so let's drop
altogether.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Acked-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: drivers: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:26 +0000 (07:11 +0100)]
ALSA: drivers: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: atmel: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:25 +0000 (07:11 +0100)]
ALSA: atmel: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: arm: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:24 +0000 (07:11 +0100)]
ALSA: arm: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aoa: Drop superfluous ioctl PCM ops
Takashi Iwai [Tue, 10 Dec 2019 06:11:23 +0000 (07:11 +0100)]
ALSA: aoa: Drop superfluous ioctl PCM ops

PCM core deals the empty ioctl field now as default(*).
Let's kill the redundant lines.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hdml-lpe-audio: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:43 +0000 (10:49 +0100)]
ALSA: hdml-lpe-audio: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: pcxhr: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:21 +0000 (10:49 +0100)]
ALSA: pcxhr: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: usb-audio: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:42 +0000 (10:49 +0100)]
ALSA: usb-audio: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: usx2y: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:41 +0000 (10:49 +0100)]
ALSA: usx2y: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ua101: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:40 +0000 (10:49 +0100)]
ALSA: ua101: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: line6: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:39 +0000 (10:49 +0100)]
ALSA: line6: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hiface: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:38 +0000 (10:49 +0100)]
ALSA: hiface: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: caiaq: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:37 +0000 (10:49 +0100)]
ALSA: caiaq: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params callback became superfluous and dropped.
The hw_free callback still remains because of the substream
deactivation sync call.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: 6fire: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:36 +0000 (10:49 +0100)]
ALSA: 6fire: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: spi: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:35 +0000 (10:49 +0100)]
ALSA: spi: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: sparc: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:34 +0000 (10:49 +0100)]
ALSA: sparc: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: sh: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:33 +0000 (10:49 +0100)]
ALSA: sh: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aica: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:32 +0000 (10:49 +0100)]
ALSA: aica: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ps3: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:31 +0000 (10:49 +0100)]
ALSA: ps3: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: pmac: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:30 +0000 (10:49 +0100)]
ALSA: pmac: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: pdaudiocf: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:29 +0000 (10:49 +0100)]
ALSA: pdaudiocf: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ymfpci: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:28 +0000 (10:49 +0100)]
ALSA: ymfpci: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: via82xx: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:27 +0000 (10:49 +0100)]
ALSA: via82xx: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: trident: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:26 +0000 (10:49 +0100)]
ALSA: trident: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: sonicvibes: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:25 +0000 (10:49 +0100)]
ALSA: sonicvibes: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: sis7019: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:24 +0000 (10:49 +0100)]
ALSA: sis7019: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: rme32: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:23 +0000 (10:49 +0100)]
ALSA: rme32: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: riptide: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:22 +0000 (10:49 +0100)]
ALSA: riptide: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: oxygen: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:20 +0000 (10:49 +0100)]
ALSA: oxygen: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: mixart: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:19 +0000 (10:49 +0100)]
ALSA: mixart: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: maestro3: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:18 +0000 (10:49 +0100)]
ALSA: maestro3: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: lx6464es: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:17 +0000 (10:49 +0100)]
ALSA: lx6464es: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: lola: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:16 +0000 (10:49 +0100)]
ALSA: lola: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: intel8x0: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:15 +0000 (10:49 +0100)]
ALSA: intel8x0: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ice1724: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:14 +0000 (10:49 +0100)]
ALSA: ice1724: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ice1712: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:13 +0000 (10:49 +0100)]
ALSA: ice1712: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hda: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:12 +0000 (10:49 +0100)]
ALSA: hda: Use managed buffer allocation

Clean up the common driver module with the new managed buffer
allocation API.  The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: fm801: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:11 +0000 (10:49 +0100)]
ALSA: fm801: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: es1938: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:10 +0000 (10:49 +0100)]
ALSA: es1938: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ens137x: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:09 +0000 (10:49 +0100)]
ALSA: ens137x: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: emu10k1: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:08 +0000 (10:49 +0100)]
ALSA: emu10k1: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The normal playback streams need a workaround for the aligned buffer,
and cannot apply the straight snd_pcm_lib_malloc() stuff, so they
remain untouched, while other streams are converted to the new managed
mode.

Most of hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: emu10k1x: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:07 +0000 (10:49 +0100)]
ALSA: emu10k1x: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: echoaudio: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:06 +0000 (10:49 +0100)]
ALSA: echoaudio: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ctxfi: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:05 +0000 (10:49 +0100)]
ALSA: ctxfi: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: cs5535: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:04 +0000 (10:49 +0100)]
ALSA: cs5535: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: cs4281: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:03 +0000 (10:49 +0100)]
ALSA: cs4281: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: cmipci: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:02 +0000 (10:49 +0100)]
ALSA: cmipci: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ca0106: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:01 +0000 (10:49 +0100)]
ALSA: ca0106: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: bt87x: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:49:00 +0000 (10:49 +0100)]
ALSA: bt87x: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: azt3328: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:59 +0000 (10:48 +0100)]
ALSA: azt3328: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aw2: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:58 +0000 (10:48 +0100)]
ALSA: aw2: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: au88x0: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:57 +0000 (10:48 +0100)]
ALSA: au88x0: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: atiixp: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:56 +0000 (10:48 +0100)]
ALSA: atiixp: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: asihpi: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:55 +0000 (10:48 +0100)]
ALSA: asihpi: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: als4000: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:54 +0000 (10:48 +0100)]
ALSA: als4000: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: als300: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:53 +0000 (10:48 +0100)]
ALSA: als300: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ali5451: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:52 +0000 (10:48 +0100)]
ALSA: ali5451: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ad1889: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:51 +0000 (10:48 +0100)]
ALSA: ad1889: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: parisc: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:50 +0000 (10:48 +0100)]
ALSA: parisc: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callbacks became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: mips: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:49 +0000 (10:48 +0100)]
ALSA: mips: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: wss: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:48 +0000 (10:48 +0100)]
ALSA: wss: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: gus: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:47 +0000 (10:48 +0100)]
ALSA: gus: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: sb: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:46 +0000 (10:48 +0100)]
ALSA: sb: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: es18xx: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:45 +0000 (10:48 +0100)]
ALSA: es18xx: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: es1688: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:44 +0000 (10:48 +0100)]
ALSA: es1688: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: cmi8330: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:43 +0000 (10:48 +0100)]
ALSA: cmi8330: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The actual removal of superfluous code will be done in ad1848 and sb
codec drivers later.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ad1816a: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:42 +0000 (10:48 +0100)]
ALSA: ad1816a: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: firewire: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:41 +0000 (10:48 +0100)]
ALSA: firewire: Use managed buffer allocation

Clean up the drivers with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Acked-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: vx: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:40 +0000 (10:48 +0100)]
ALSA: vx: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: pcsp: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:39 +0000 (10:48 +0100)]
ALSA: pcsp: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() are dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: ml403: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:38 +0000 (10:48 +0100)]
ALSA: ml403: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous (they were only
useless debug prints) and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: dummy: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:37 +0000 (10:48 +0100)]
ALSA: dummy: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aloop: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:36 +0000 (10:48 +0100)]
ALSA: aloop: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params callback became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: atmel: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:35 +0000 (10:48 +0100)]
ALSA: atmel: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_free_free callbacks became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aaci: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:34 +0000 (10:48 +0100)]
ALSA: aaci: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped, and the if block is
flattened accordingly.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: aoa: Use managed buffer allocation
Takashi Iwai [Mon, 9 Dec 2019 09:48:33 +0000 (10:48 +0100)]
ALSA: aoa: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params callbacks became superfluous and got dropped.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hda/realtek - Line-out jack doesn't work on a Dell AIO
Hui Wang [Wed, 11 Dec 2019 05:13:21 +0000 (13:13 +0800)]
ALSA: hda/realtek - Line-out jack doesn't work on a Dell AIO

After applying the fixup ALC274_FIXUP_DELL_AIO_LINEOUT_VERB, the
Line-out jack works well. And instead of adding a new set of pin
definition in the pin_fixup_tbl, we put a more generic matching entry
in the fallback_pin_fixup_tbl.

Cc: <[email protected]>
Signed-off-by: Hui Wang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hda: Use standard waitqueue for RIRB wakeup
Takashi Iwai [Tue, 10 Dec 2019 14:57:27 +0000 (15:57 +0100)]
ALSA: hda: Use standard waitqueue for RIRB wakeup

The HD-audio CORB/RIRB communication was programmed in a way that was
documented in the reference in decades ago, which is essentially a
polling in the waiter side.  It's working fine but costs CPU cycles on
some platforms that support only slow communications.  Also, for some
platforms that had unreliable communications, we put longer wait time
(2 ms), which accumulate quite long time if you execute many verbs in
a shot (e.g. at the initialization or resume phase).

This patch attempts to improve the situation by introducing the
standard waitqueue in the RIRB waiter side instead of polling.  The
test results on my machine show significant improvements.  The time
spent for "cat /proc/asound/card*/codec#*" were changed like:

* Intel SKL + Realtek codec
  before the patch:
   0.00user 0.04system 0:00.10elapsed 40.0%CPU
  after the patch:
   0.00user 0.01system 0:00.10elapsed 10.0%CPU

* Nvidia GP107GL + Nvidia HDMI codec
  before the patch:
   0.00user 0.00system 0:02.76elapsed 0.0%CPU
  after the patch:
   0.00user 0.00system 0:00.01elapsed 17.0%CPU

So, for Intel chips, the total time is same, while the total time is
greatly reduced (from 2.76 to 0.01s) for Nvidia chips.
The only negative data here is the increase of CPU time for Nvidia,
but this is the unavoidable cost for faster wakeups, supposedly.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoMerge branch 'for-linus' into for-next
Takashi Iwai [Tue, 10 Dec 2019 17:22:09 +0000 (18:22 +0100)]
Merge branch 'for-linus' into for-next

Back-merge the 5.5-devel branch for fixing FireWire bugs.
The upcoming PCM API update patchset relies on these.

Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: hda/hdmi - Fix duplicate unref of pci_dev
Lukas Wunner [Tue, 10 Dec 2019 13:39:50 +0000 (14:39 +0100)]
ALSA: hda/hdmi - Fix duplicate unref of pci_dev

Nicholas Johnson reports a null pointer deref as well as a refcount
underflow upon hot-removal of a Thunderbolt-attached AMD eGPU.
He's bisected the issue down to commit 586bc4aab878 ("ALSA: hda/hdmi -
fix vgaswitcheroo detection for AMD").

The commit iterates over PCI devices using pci_get_class() and
unreferences each device found, even though pci_get_class()
subsequently unreferences the device as well.  Fix it.

Fixes: 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD")
Link: https://lore.kernel.org/r/PSXP216MB0438BFEAA0617283A834E11580580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM/
Reported-and-tested-by: Nicholas Johnson <[email protected]>
Signed-off-by: Lukas Wunner <[email protected]>
Reviewed-by: Alex Deucher <[email protected]>
Cc: Mika Westerberg <[email protected]>
Cc: Alexander Deucher <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Link: https://lore.kernel.org/r/77aa6c01aefe1ebc4004e87b0bc714f2759f15c4.1575985006.git.lukas@wunner.de
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoASoC: Intel: common: work-around incorrect ACPI HID for CML boards
Amery Song [Tue, 10 Dec 2019 00:48:54 +0000 (18:48 -0600)]
ASoC: Intel: common: work-around incorrect ACPI HID for CML boards

On CML boards with the RT5682 headset codec and RT1011 speaker
amplifier, the platform firmware exposes three ACPI HIDs
(10EC568210EC1011 and MX98357A). The last HID is a mistake in
DSDT tables, which causes the wrong machine driver to be loaded.

This patch changes the key used to identify boards and changes the
order of entries in the table to load the correct machine driver.
The order does matter and should not be modified to work-around this
firmware issue.

Signed-off-by: Amery Song <[email protected]>
Signed-off-by: Keyon Jie <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: SOF: Intel: split cht and byt debug window sizes
Curtis Malainey [Tue, 10 Dec 2019 00:48:52 +0000 (18:48 -0600)]
ASoC: SOF: Intel: split cht and byt debug window sizes

Turns out SSP 3-5 are only available on cht, to avoid dumping on
undefined registers let's split the definition.

Signed-off-by: Curtis Malainey <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: SOF: loader: fix snd_sof_fw_parse_ext_data
Karol Trzcinski [Tue, 10 Dec 2019 00:48:49 +0000 (18:48 -0600)]
ASoC: SOF: loader: fix snd_sof_fw_parse_ext_data

An error occurs during parsing more than one ext_data from the mailbox, because
of invalid data offset handling. Fix by removing the incorrect duplicate
increment of the offset.

The return value is also reset in the switch case. This does not change the
behavior but improves readability - there is no longer a need to check what the
return value of get_ext_windows is.

Signed-off-by: Karol Trzcinski <[email protected]>
Signed-off-by: Bartosz Kokoszko <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: SOF: loader: snd_sof_fw_parse_ext_data log warning on unknown header
Karol Trzcinski [Tue, 10 Dec 2019 00:48:48 +0000 (18:48 -0600)]
ASoC: SOF: loader: snd_sof_fw_parse_ext_data log warning on unknown header

Added warning log when found some unknown FW boot ext header,
to improve debuggability.

Signed-off-by: Karol Trzcinski <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: simple-card: Don't create separate link when platform is present
Daniel Baluta [Mon, 9 Dec 2019 13:53:53 +0000 (15:53 +0200)]
ASoC: simple-card: Don't create separate link when platform is present

In normal sound case all DAIs are detected as CPU-Codec.
simple_dai_link_of supports the presence of a platform but it counts
it as a CPU DAI resulting in the creation of an extra link.

Adding a platform property to a link description like:

simple-audio-card,dai-link {
cpu {
sound-dai = <&sai1>;
};
plat {
sound-dai = <&dsp>;
};
codec {
sound-dai = <&wm8960>;
}

will result in the creation of two links:
* sai1 <-> wm8960
* dsp  <-> wm8960

which is obviously not what we want. We just want one single link
with:
* sai1 <-> wm8960 (and platform set to dsp).

Signed-off-by: Daniel Baluta <[email protected]>
Acked-by: Kuninori Morimoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: topology: Check return value for soc_tplg_pcm_create()
Dragos Tarcatu [Tue, 10 Dec 2019 00:39:39 +0000 (18:39 -0600)]
ASoC: topology: Check return value for soc_tplg_pcm_create()

The return value of soc_tplg_pcm_create() is currently not checked
in soc_tplg_pcm_elems_load(). If an error is to occur there, the
topology ignores it and continues loading.

Fix that by checking the status and rejecting the topology on error.

Reviewed-by: Ranjani Sridharan <[email protected]>
Signed-off-by: Dragos Tarcatu <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoASoC: topology: Check return value for snd_soc_add_dai_link()
Dragos Tarcatu [Tue, 10 Dec 2019 00:39:38 +0000 (18:39 -0600)]
ASoC: topology: Check return value for snd_soc_add_dai_link()

snd_soc_add_dai_link() might fail. This situation occurs for
instance in a very specific use case where a PCM device and a
Back End DAI link are given identical names in the topology.
When this happens, soc_new_pcm_runtime() fails and then
snd_soc_add_dai_link() returns -ENOMEM when called from
soc_tplg_fe_link_create(). Because of that, the link will not
get added into the card list, so any attempt to remove it later
ends up in a panic.

Fix that by checking the return status and free the memory in case
of an error.

Reviewed-by: Ranjani Sridharan <[email protected]>
Signed-off-by: Dragos Tarcatu <[email protected]>
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoALSA: fireface: fix return value in error path of isochronous resources reservation
Takashi Sakamoto [Mon, 9 Dec 2019 15:05:41 +0000 (00:05 +0900)]
ALSA: fireface: fix return value in error path of isochronous resources reservation

Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <[email protected]> #5.3+
Fixes: 55162d2bb0e8 ("ALSA: fireface: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoALSA: oxfw: fix return value in error path of isochronous resources reservation
Takashi Sakamoto [Mon, 9 Dec 2019 15:03:04 +0000 (00:03 +0900)]
ALSA: oxfw: fix return value in error path of isochronous resources reservation

Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <[email protected]> #5.3+
Fixes: 4f380d007052 ("ALSA: oxfw: configure packet format in pcm.hw_params callback")
Signed-off-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <[email protected]>
5 years agoASoC: core: only flush inited work during free
Curtis Malainey [Thu, 28 Nov 2019 01:13:58 +0000 (17:13 -0800)]
ASoC: core: only flush inited work during free

There are many paths to soc_free_pcm_runtime which can both have and
have not yet inited the workqueue yet. When we flush the queue when we
have not yet inited the queue we cause warnings to be printed.

An example is soc_cleanup_card_resources which is called by
snd_soc_bind_card which has multiple failure points before and after
soc_link_init -> soc_new_pcm which is where the queue is inited.

Signed-off-by: Curtis Malainey <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
5 years agoALSA: firewire-motu: fix double unlocked 'motu->mutex'
Takashi Sakamoto [Sun, 8 Dec 2019 23:22:26 +0000 (08:22 +0900)]
ALSA: firewire-motu: fix double unlocked 'motu->mutex'

Mutex is doubly unlocked in some error path of pcm.open. This commit fixes
ALSA firewire-motu driver in Linux kernel v5.5.

Reported-by: kbuild test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Fixes: 3fd80b200388 ("ALSA: firewire-motu: use the same size of period for PCM substream in AMDTP streams")
Fixes: 0f5482e7875b ("ALSA: firewire-motu: share PCM buffer size for both direction")
Signed-off-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
This page took 0.106742 seconds and 4 git commands to generate.