net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

With the newly added support for IFLA_VF_VLAN_LIST netlink messages,
we get a warning about potential uninitialized variable use in
the parsing of the user input when enabling the -Wmaybe-uninitialized
warning:

net/core/rtnetlink.c: In function 'do_setvfinfo':
net/core/rtnetlink.c:1756:9: error: 'ivvl$' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I have not been able to prove whether it is possible to arrive in
this code with an empty IFLA_VF_VLAN_LIST block, but if we do,
then ndo_set_vf_vlan gets called with uninitialized arguments.

This adds an explicit check for an empty list, making it obvious
to the reader and the compiler that this cannot happen.

Fixes: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad support")
Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: Moshe Shemesh <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

net: pktgen: fix pkt_size

The commit 879c7220e828 ("net: pktgen: Observe needed_headroom
of the device") increased the 'pkt_overhead' field value by
LL_RESERVED_SPACE.
As a side effect the generated packet size, computed as:

/* Eth + IPh + UDPh + mpls */
datalen = pkt_dev->cur_pkt_size - 14 - 20 - 8 -
  pkt_dev->pkt_overhead;

is decreased by the same value.
The above changed slightly the behavior of existing pktgen users,
and made the procfs interface somewhat inconsistent.
Fix it by restoring the previous pkt_overhead value and using
LL_RESERVED_SPACE as extralen in skb allocation.
Also, change pktgen_alloc_skb() to only partially reserve
the headroom to allow the caller to prefetch from ll header
start.

v1 -> v2:
 - fixed some typos in the comments

Fixes: 879c7220e828 ("net: pktgen: Observe needed_headroom of the device")
Suggested-by: Ben Greear <[email protected]>
Signed-off-by: Paolo Abeni <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

net: fec: set mac address unconditionally

If the mac address origin is not dt, you can only safely assign a mac
address after "link up" of the device. If the link is off the clocks are
disabled and because of issues assigning registers when clocks are off the
new mac address cannot be written in .ndo_set_mac_address() on some soc's.
This fix sets the mac address unconditionally in fec_restart(...) and
ensures consistency between fec registers and the network layer.

Signed-off-by: Gavin Schenk <[email protected]>
Acked-by: Fugang Duan <[email protected]>
Acked-by: Uwe Kleine-König <[email protected]>
Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address")
Signed-off-by: David S. Miller <[email protected]>

net: ethernet: mediatek: mark symbols static where possible

We get 2 warnings when building kernel with W=1:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2041:5: warning: no previous prototype for 'mtk_get_link_ksettings' [-Wmissing-prototypes]
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2052:5: warning: no previous prototype for 'mtk_set_link_ksettings' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

cxgb4: mark cxgb_setup_tc() static

We get 1 warning when building kernel with W=1:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:2715:5: warning: no previous prototype for 'cxgb_setup_tc' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.

Signed-off-by: Baoyou Xie <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

Merge branch 'topic/unmap_cleanup' into for-linus

Merge branch 'topic/tegra' into for-linus

Merge branch 'topic/ste_dma40' into for-linus

Merge branch 'topic/pl330' into for-linus

Merge branch 'topic/omap' into for-linus

Merge branch 'topic/no_irq' into for-linus

Merge branch 'topic/mv_xor' into for-linus

Merge branch 'topic/k3' into for-linus

ipv6 addrconf: remove addrconf_sysctl_hop_limit()

This is an effective no-op in terms of user observable behaviour.

By preventing the overwrite of non-null extra1/extra2 fields
in addrconf_sysctl() we can enable the use of proc_dointvec_minmax().

This allows us to eliminate the constant min/max (1..255) trampoline
function that is addrconf_sysctl_hop_limit().

This is nice because it simplifies the code, and allows future
sysctls with constant min/max limits to also not require trampolines.

We still can't eliminate the trampoline for mtu because it isn't
actually a constant (it depends on other tunables of the device)
and thus requires at-write-time logic to enforce range.

Signed-off-by: Maciej Żenczykowski <[email protected]>
Acked-by: Erik Kline <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

Merge branch 'topic/iommu' into for-linus

Merge branch 'topic/ioatdma' into for-linus

Merge branch 'topic/imx' into for-linus

Merge branch 'topic/hsu' into for-linus

Merge branch 'topic/err_reporting' into for-linus

Signed-off-by: Vinod Koul <[email protected]>
Conflicts:
drivers/dma/cppi41.c

Merge branch 'topic/dmatest' into for-linus

Merge branch 'topic/cppi' into for-linus

Merge branch 'topic/core' into for-linus

Merge branch 'topic/compile_test' into for-linus

netfilter: bridge: clarify bridge/netfilter message

When using bridge without bridge netfilter enabled the message
displayed is rather confusing and leads to belive that a deprecated
feature is in use. Use IS_MODULE to be explicit that the message only
affects users which use bridge netfilter as module and reword the
message.

Signed-off-by: Stefan Agner <[email protected]>
Acked-by: Florian Westphal <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Three sets of overlapping changes.  Nothing serious.

Signed-off-by: David S. Miller <[email protected]>

Linux 4.8

Merge branch 'xfs-4.9-log-recovery-fixes' into for-next

Merge branch 'iomap-4.9-dax' into for-next

Merge branch 'xfs-4.9-delalloc-rework' into for-next

Merge branch 'xfs-4.9-reflink-prep' into for-next

Merge branch 'iomap-4.9-misc-fixes-1' into for-next

fs: update atime before I/O in generic_file_read_iter

After the call to ->direct_IO the final reference to the file might have
been dropped by aio_complete already, and the call to file_accessed might
cause a use after free.

Instead update the access time before the I/O, similar to how we
update the time stamps before writes.

Signed-off-by: Christoph Hellwig <[email protected]>
Reviewed-by: Dave Chinner <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>

xfs: update atime before I/O in xfs_file_dio_aio_read

After the call to __blkdev_direct_IO the final reference to the file
might have been dropped by aio_complete already, and the call to
file_accessed might cause a use after free.

Instead update the access time before the I/O, similar to how we
update the time stamps before writes.

Signed-off-by: Christoph Hellwig <[email protected]>
Reported-and-tested-by: Darrick J. Wong <[email protected]>
Reviewed-by: Darrick J. Wong <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>

ext2: fix possible integer truncation in ext2_iomap_begin

For 32-bit architectures we need to cast first_block to u64 before
shifting it left.

Signed-off-by: Christoph Hellwig <[email protected]>
Reported-by: Jan Kara <[email protected]>
Reviewed-by: Dave Chinner <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>

Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm

Pull ARM fixes from Russell King:
 "Three relatively small fixes for ARM:

   - Roger noticed that dma_max_pfn() was calculating the upper limit
     wrongly, by adding the PFN offset of memory twice.

   - A fix from Robin to correct parsing of MPIDR values when the
     address size is larger than one BE32 unit.

   - A fix from Srinivas to ensure that we do not rely on the boot
     loader (or previous Linux kernel) setting the translation table
     base register a certain way in the decompressor, which can lead to
     crashes"

* 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm:
  ARM: 8618/1: decompressor: reset ttbcr fields to use TTBR0 on ARMv7
  ARM: 8617/1: dma: fix dma_max_pfn()
  ARM: 8616/1: dt: Respect property size when parsing CPUs

ARM: 8618/1: decompressor: reset ttbcr fields to use TTBR0 on ARMv7

If the bootloader uses the long descriptor format and jumps to
kernel decompressor code, TTBCR may not be in a right state.
Before enabling the MMU, it is required to clear the TTBCR.PD0
field to use TTBR0 for translation table walks.

The commit dbece45894d3a ("ARM: 7501/1: decompressor:
reset ttbcr for VMSA ARMv7 cores") does the reset of TTBCR.N, but
doesn't consider all the bits for the size of TTBCR.N.

Clear TTBCR.PD0 field and reset all the three bits of TTBCR.N to
indicate the use of TTBR0 and the correct base address width.

Fixes: dbece45894d3 ("ARM: 7501/1: decompressor: reset ttbcr for VMSA ARMv7 cores")
Acked-by: Robin Murphy <[email protected]>
Signed-off-by: Srinivas Ramana <[email protected]>
Signed-off-by: Russell King <[email protected]>

Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull x86 fixes from Thomas Gleixner:
 "The last regression fixes for 4.8 final:

   - Two patches addressing the fallout of the CR4 optimizations which
     caused CR4-less machines to fail.

   - Fix the VDSO build on big endian machines

   - Take care of FPU initialization if no CPUID is available otherwise
     task struct size ends up being zero

   - Fix up context tracking in case load_gs_index fails"

* 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  x86/entry/64: Fix context tracking state warning when load_gs_index fails
  x86/boot: Initialize FPU and X86_FEATURE_ALWAYS even if we don't have CPUID
  x86/vdso: Fix building on big endian host
  x86/boot: Fix another __read_cr4() case on 486
  x86/init: Fix cr4_init_shadow() on CR4-less machines

Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus

Pull MIPS fixes from Ralf Baechle:
 "Another round of fixes:

   - CM: Fix mips_cm_max_vp_width for non-MT kernels on MT systems
   - CPS: Avoid BUG() when offlining pre-r6 CPUs
   - DEC: Avoid gas warnings due to suspicious instruction scheduling by
     manually expanding assembler macros.
   - FTLB: Fix configuration by moving confiuguratoin after probing
   - FTLB: clear execution hazard after changing FTLB enable
   - Highmem: Fix detection of unsupported highmem with cache aliases
   - I6400: Don't touch FTLBP chicken bits
   - microMIPS: Fix BUILD_ROLLBACK_PROLOGUE
   - Malta: Fix IOCU disable switch read for MIPS64
   - Octeon: Fix probing of devices attached to GPIO lines
   - uprobes: Misc small fixes"

* 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus:
  MIPS: CM: Fix mips_cm_max_vp_width for non-MT kernels on MT systems
  MIPS: Fix detection of unsupported highmem with cache aliases
  MIPS: Malta: Fix IOCU disable switch read for MIPS64
  MIPS: Fix BUILD_ROLLBACK_PROLOGUE for microMIPS
  MIPS: clear execution hazard after changing FTLB enable
  MIPS: Configure FTLB after probing TLB sizes from config4
  MIPS: Stop setting I6400 FTLBP
  MIPS: DEC: Avoid la pseudo-instruction in delay slots
  MIPS: Octeon: mark GPIO controller node not populated after IRQ init.
  MIPS: uprobes: fix use of uninitialised variable
  MIPS: uprobes: remove incorrect set_orig_insn
  MIPS: fix uretprobe implementation
  MIPS: smp-cps: Avoid BUG() when offlining pre-r6 CPUs

Staging: fbtft: Fix bug in fbtft-core

Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug
in fbtft-core where fps is always 0, this is because variable
update_time is not assigned correctly.

Signed-off-by: Ksenija Stanojevic <[email protected]>
Fixes: 367e8560e8d7 ("Staging: fbtbt: Replace timespec with ktime_t")
Cc: stable <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc

Pull sparc fixes from David Miller:

 1) Fix section mismatches in some builds, from Paul Gortmaker.

 2) Need to count huge zero page mappings when doing TSB sizing, from
    Mike Kravetz.

 3) Fix handing of cpu_possible_mask when nr_cpus module option is
    specified, from Atish Patra.

 4) Don't allocate irq stacks until nr_irqs has been processed, also
    from Atish Patra.

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
  sparc64: Fix non-SMP build.
  sparc64: Fix irq stack bootmem allocation.
  sparc64: Fix cpu_possible_mask if nr_cpus is set
  sparc64 mm: Fix more TSB sizing issues
  sparc64: fix section mismatch in find_numa_latencies_for_group

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Pull networking fixes from David Miller:

 1) Fix wrong TCP checksums on MTU probing when checksum offloading is
    disabled, from Douglas Caetano dos Santos.

 2) Fix qdisc backlog updates in qfq and sfb schedulers, from Cong Wang.

 3) Route lookup flow key protocol value is wrong in ip6gre_xmit_other(),
    fix from Lance Richardson.

 4) Scheduling while atomic in multicast routing code of ipv4 and ipv6,
    fix from Nikolay Aleksandrov.

 5) Fix packet alignment in fec driver, from Eric Nelson.

 6) Fix perf regression in sctp due to struct layout and cache misses,
    from Xin Long.

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net:
  sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock
  sctp: change to check peer prsctp_capable when using prsctp polices
  sctp: remove prsctp_param from sctp_chunk
  sctp: move sent_count to the memory hole in sctp_chunk
  tg3: Avoid NULL pointer dereference in tg3_io_error_detected()
  act_ife: Fix false encoding
  act_ife: Fix external mac header on encode
  VSOCK: Don't dec ack backlog twice for rejected connections
  Revert "net: ethernet: bcmgenet: use phydev from struct net_device"
  net: fec: align IP header in hardware
  net: fec: remove QUIRK_HAS_RACC from i.mx27
  net: fec: remove QUIRK_HAS_RACC from i.mx25
  ipmr, ip6mr: fix scheduling while atomic and a deadlock with ipmr_get_route
  ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()
  tcp: fix a compile error in DBGUNDO()
  tcp: fix wrong checksum calculation on MTU probing
  sch_sfb: keep backlog updated with qlen
  sch_qfq: keep backlog updated with qlen
  can: dev: fix deadlock reported after bus-off

staging: rtl8188eu: fix double unlock error in rtw_resume_process()

Fix following static checker warning:
    drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process()
    error: double unlock 'mutex:&pwrpriv->mutex_lock'

Fixes: eaf47b713b60 ("staging: rtl8188eu: fix missing unlock on error in rtw_resume_process()")
Reported-By: Dan Carpenter <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove GEN_MLME_EXT_HANDLER macro

GEN_MLME_EXT_HANDLER is redundant macro.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove GEN_DRV_CMD_HANDLER macro

This macro does not used.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove GEN_EVT_CODE macro

GEN_EVT_CODE is redundant macro.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove GEN_CMD_CODE macro

GEN_CMD_CODE is redundant macro.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove pkt_newalloc member of the recv_buf structure

This member does not used.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove rtw_handle_dualmac declaration

It is a declaration of the non-existent function.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: remove (RGTRY|BSSID)_(OFT|SZ) macros

These macros does not used.

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:r8188eu: change rtl8188e_process_phy_info function argument type

prframe is (void *), but function used only with (struct recv_frame *).

Signed-off-by: Ivan Safonov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: fsl-mc: Remove blank lines

Remove multiple blank lines as reported by checkpatch

Signed-off-by: Ramiro Oliveira <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: fsl-mc: Fix unaligned * in block comments

Align the * in some block comments as reported by checkpatch.

Signed-off-by: Ramiro Oliveira <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: comedi: Align the * in block comments

Align the * on each line of block comments as reported by checkpatch

Signed-off-by: Ramiro Oliveira <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging : ks7010 : Fix block comments warninig

Move final */ to a new line, to conform to
the kernel coding style for block comments.

Issue found by checkpatch.

Signed-off-by: Muraru Mihaela <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: vt6655: Remove explicit NULL comparison using Coccinelle

Remove the explicit NULL comparison and rewrite in a compact form.

Signed-off-by: shyam saini <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: core: rtw_xmit: Use macros instead of constants

Replace the 0x888e with ETH_P_PAE and 0x0806 with ETH_P_ARP.
These macros can be found in drivers/staging/rtl8192e/rtllib.h

Hexadecimal numbers are not case sensitive,
therefore 0x888e is equal with 0x888E.

The modifications improve the readability of the code.

Signed-off-by: Georgiana Rodica Chelu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: core: rtw_xmit: Move constant of the right side

Constants should be on the right side of comparisons.

Issue found by checkpatch.pl script.

Signed-off-by: Georgiana Rodica Chelu <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: dgnc: Fix lines longer than 80 characters

All the chunks of the patch apply to comments save the first one.

Signed-off-by: Fernando Apesteguia <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: dgnc: constify attribute_group structures

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property  can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
   6248    1024       0    7272    1c68
drivers/staging/dgnc/dgnc_sysfs.o

File size after:
   text    data     bss     dec     hex filename
   6288     960       0    7248    1c50
drivers/staging/dgnc/dgnc_sysfs.o

Signed-off-by: Bhumika Goyal <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: most: hdm-dim2: constify attribute_group structures

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1,e2;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
    509     160       0     669     29d
drivers/staging/most/hdm-dim2/dim2_sysfs.o

File size after:
   text    data     bss     dec     hex filename
    565      96       0     661     295
drivers/staging/most/hdm-dim2/dim2_sysfs.o

Signed-off-by: Bhumika Goyal <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wilc1000: remove unnecessary braces

Fix checkpatch warning "braces {} are not necessary for single statement
blocks" to conform to linux kernel coding style.

Signed-off-by: Elizabeth Ferdman <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wilc1000: wilc_spi: Remove unnecessary blank lines

Remove unnecessary blank lines to resolve checkpatch issue.

Signed-off-by: Namrata A Shettar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wilc1000: wilc_spi: Compress return logic

Compress return logic. Done using Coccinelle :
@@
local idexpression ret;
expression e;
@@

-ret=
+return
  e;
  -return ret;

Signed-off-by: Namrata A Shettar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wilc1000: wilc_wlan: Compress return logic

Compress return logic. Done using Coccinelle :
@@
local idexpression ret;
expression e;
@@

-ret=
+return
  e;
  -return ret;

Signed-off-by: Namrata A Shettar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: fbtft: fix NULL comparison checkpatch warning

Fixed the following checkpatch warnings (task #10 of eudyptula challenge):
- NULL comparison rewritten to use '!' operator

Signed-off-by: Carlos Palminha <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: rts5208: Fix indentation warnings

Fix code indentation warnings detected by checkpatch.pl

Signed-off-by: Wayne Porter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rts5208: Replace explicit NULL comparison

Replace explicit NULL comparison to resolve checkpatch issues.

Signed-off-by: Namrata A Shettar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rts5208: Add space around binary operators

Add space around binary operators to resolve checkpatch issue.

Signed-off-by: Namrata A Shettar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: speakup: constify attribute_group structures

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property  can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
   7551    1440      16    9007    232f
drivers/staging/speakup/kobjects.o

File size after:
   text    data     bss     dec     hex filename
   7671    1312      16    8999    2327
drivers/staging/speakup/kobjects.o

Signed-off-by: Bhumika Goyal <[email protected]>
Acked-by: Samuel Thibault <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: Fix block comments style warnings in hfa384x.h

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: Block comments use * on subsequent lines

No more warnings block comments warnings for this file.

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_metacmd_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_usbctlxq_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_usbctlx_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_rridresult_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_cmdresult_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdrec_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_end_of_pda_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_manf_testi_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_manf_testsp_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_hfo_delay_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_nic_config_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_chcali_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_chcalsp_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_ifrf_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_shadow_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_hfa3861_baseline_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_rfr_setting_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_ifr_setting_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_trimdac_setup_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_level_comp_setup_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_vgdac_setup_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_refdac_setup_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_temptype_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_privacy_option_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_default_channel_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_allowed_channel_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_regdomain_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_mkk_callname_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdr_mac_address_t

Signed-off-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>