From: Dan Carpenter Date: Tue, 7 Feb 2017 13:20:08 +0000 (+0300) Subject: pinctrl: intel: unlock on error in intel_config_set_pull() X-Git-Tag: v4.11-rc1~133^2~1 X-Git-Url: https://repo.jachan.dev/linux.git/commitdiff_plain/aa1dd80f80ccf3a47227ab42625e7bbacd5ff272 pinctrl: intel: unlock on error in intel_config_set_pull() We need to unlock before returning -EINVAL on this error path. Fixes: 04cc058f0c52 ("pinctrl: intel: Add support for 1k additional pull-down") Signed-off-by: Dan Carpenter Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 523264463d35..592b465e981e 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -599,8 +599,10 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned pin, value |= PADCFG1_TERM_5K << PADCFG1_TERM_SHIFT; break; case 1000: - if (!(community->features & PINCTRL_FEATURE_1K_PD)) - return -EINVAL; + if (!(community->features & PINCTRL_FEATURE_1K_PD)) { + ret = -EINVAL; + break; + } value |= PADCFG1_TERM_1K << PADCFG1_TERM_SHIFT; break; default: