From: Liu Jian <liujian56@huawei.com>
Date: Mon, 20 Jul 2020 14:33:15 +0000 (+0800)
Subject: ieee802154: fix one possible memleak in ca8210_dev_com_init
X-Git-Tag: v5.9-rc7~34^2~71^2~2
X-Git-Url: https://repo.jachan.dev/linux.git/commitdiff_plain/88f46b3fe2ac41c381770ebad9f2ee49346b57a2

ieee802154: fix one possible memleak in ca8210_dev_com_init

We should call destroy_workqueue to destroy mlme_workqueue in error branch.

Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Link: https://lore.kernel.org/r/20200720143315.40523-1-liujian56@huawei.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
---

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index e04c3b60cae7..4eb64709d44c 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2925,6 +2925,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
 	);
 	if (!priv->irq_workqueue) {
 		dev_crit(&priv->spi->dev, "alloc of irq_workqueue failed!\n");
+		destroy_workqueue(priv->mlme_workqueue);
 		return -ENOMEM;
 	}