From: Vasily Averin <vvs@virtuozzo.com>
Date: Thu, 25 Jun 2020 09:39:51 +0000 (+0300)
Subject: fuse: don't ignore errors from fuse_writepages_fill()
X-Git-Tag: v5.8-rc6~17^2~1
X-Git-Url: https://repo.jachan.dev/linux.git/commitdiff_plain/7779b047a57f6824a43d0e1f70de2741b7426b9d

fuse: don't ignore errors from fuse_writepages_fill()

fuse_writepages() ignores some errors taken from fuse_writepages_fill() I
believe it is a bug: if .writepages is called with WB_SYNC_ALL it should
either guarantee that all data was successfully saved or return error.

Fixes: 26d614df1da9 ("fuse: Implement writepages callback")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index a6a5aeff258d..9895ce2d7023 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2165,10 +2165,8 @@ static int fuse_writepages(struct address_space *mapping,
 
 	err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data);
 	if (data.wpa) {
-		/* Ignore errors if we can write at least one page */
 		WARN_ON(!data.wpa->ia.ap.num_pages);
 		fuse_writepages_send(&data);
-		err = 0;
 	}
 	if (data.ff)
 		fuse_file_put(data.ff, false, false);