From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 19 Jun 2018 14:32:05 +0000 (+0100)
Subject: ARM: 8776/1: clkdev: Remove duplicated negative index check from __of_clk_get()
X-Git-Tag: v4.19-rc1~189^2~1
X-Git-Url: https://repo.jachan.dev/linux.git/commitdiff_plain/76672e2e5b86d330e236eabe3ca3d471a581df57

ARM: 8776/1: clkdev: Remove duplicated negative index check from __of_clk_get()

__of_clk_get() calls of_parse_phandle_with_args(), which rejects
negative indices since commit bd69f73f2c81eed9 ("of: Create function for
counting number of phandles in a property").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 7513411140b6..02fcee2012e0 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -35,9 +35,6 @@ static struct clk *__of_clk_get(struct device_node *np, int index,
 	struct clk *clk;
 	int rc;
 
-	if (index < 0)
-		return ERR_PTR(-EINVAL);
-
 	rc = of_parse_phandle_with_args(np, "clocks", "#clock-cells", index,
 					&clkspec);
 	if (rc)