From: Maxime Roussin-Bélanger <maxime.roussinbelanger@gmail.com>
Date: Tue, 31 Jul 2018 20:13:21 +0000 (-0400)
Subject: iio: light: si1133: fix uninitialized resp variable
X-Git-Tag: v4.19-rc1~101^2~139^2
X-Git-Url: https://repo.jachan.dev/linux.git/commitdiff_plain/496fb59e1274086d0c67681fb1369e9941660dd9

iio: light: si1133: fix uninitialized resp variable

Read response register to detect any error.

Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger@gmail.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
index 5ac22c46da1f..015a21f0c2ef 100644
--- a/drivers/iio/light/si1133.c
+++ b/drivers/iio/light/si1133.c
@@ -409,6 +409,9 @@ static int si1133_command(struct si1133_data *data, u8 cmd)
 			err = -ETIMEDOUT;
 			goto out;
 		}
+		err = regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp);
+		if (err)
+			goto out;
 	} else {
 		err = regmap_read_poll_timeout(data->regmap,
 					       SI1133_REG_RESPONSE0, resp,