]> Git Repo - linux.git/commitdiff
net: aquantia: fixed enable unicast on 32 macvlan
authorIgor Russkikh <[email protected]>
Fri, 9 Nov 2018 11:53:59 +0000 (11:53 +0000)
committerDavid S. Miller <[email protected]>
Fri, 9 Nov 2018 23:38:10 +0000 (15:38 -0800)
Fixed a condition mistake due to which macvlans unicast
item number 32 was not added in the unicast filter.

The consequence is that when exactly 32 macvlans are created
on NIC, the last created macvlan receives no traffic because
its MAC was not registered in HW.

Fixes: 94b3b542303f ("net: aquantia: vlan unicast address list correct handling")
Signed-off-by: Igor Russkikh <[email protected]>
Tested-by: Nikita Danilov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/ethernet/aquantia/atlantic/aq_nic.c

index 0011a3f2f67272d27a4be0e83dc02ed2eb86f6c0..b5e7c98f424ca19b68fd915e581b004e60a2b1c9 100644 (file)
@@ -600,7 +600,7 @@ int aq_nic_set_multicast_list(struct aq_nic_s *self, struct net_device *ndev)
                }
        }
 
-       if (i > 0 && i < AQ_HW_MULTICAST_ADDRESS_MAX) {
+       if (i > 0 && i <= AQ_HW_MULTICAST_ADDRESS_MAX) {
                packet_filter |= IFF_MULTICAST;
                self->mc_list.count = i;
                self->aq_hw_ops->hw_multicast_list_set(self->aq_hw,
This page took 0.057417 seconds and 4 git commands to generate.