]> Git Repo - linux.git/commit
fanotify: Use interruptible wait when waiting for permission events
authorJan Kara <[email protected]>
Tue, 8 Jan 2019 14:18:02 +0000 (15:18 +0100)
committerJan Kara <[email protected]>
Mon, 18 Feb 2019 11:41:16 +0000 (12:41 +0100)
commitfabf7f29b3e2ce5ed9741bf06f3583cd7e82ed1c
treee835a20d5acb44c7a58cf5c279a638f5d60e24d5
parent40873284d7106fc0f0f4d2deae74b38fb18342cc
fanotify: Use interruptible wait when waiting for permission events

When waiting for response to fanotify permission events, we currently
use uninterruptible waits. That makes code simple however it can cause
lots of processes to end up in uninterruptible sleep with hard reboot
being the only alternative in case fanotify listener process stops
responding (e.g. due to a bug in its implementation). Uninterruptible
sleep also makes system hibernation fail if the listener gets frozen
before the process generating fanotify permission event.

Fix these problems by using interruptible sleep for waiting for response
to fanotify event. This is slightly tricky though - we have to
detect when the event got already reported to userspace as in that
case we must not free the event. Instead we push the responsibility for
freeing the event to the process that will write response to the
event.

Reported-by: Orion Poplawski <[email protected]>
Reported-by: Konstantin Khlebnikov <[email protected]>
Reviewed-by: Amir Goldstein <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
fs/notify/fanotify/fanotify.c
fs/notify/fanotify/fanotify.h
fs/notify/fanotify/fanotify_user.c
This page took 0.05922 seconds and 4 git commands to generate.