]> Git Repo - linux.git/commit
gro: fix ownership transfer
authorAntoine Tenart <[email protected]>
Tue, 26 Mar 2024 11:33:59 +0000 (12:33 +0100)
committerDavid S. Miller <[email protected]>
Fri, 29 Mar 2024 11:30:44 +0000 (11:30 +0000)
commited4cccef64c1d0d5b91e69f7a8a6697c3a865486
tree1c4251d0981e64f8af2dabec5460b5a61813c52e
parent3d010c8031e39f5fa1e8b13ada77e0321091011f
gro: fix ownership transfer

If packets are GROed with fraglist they might be segmented later on and
continue their journey in the stack. In skb_segment_list those skbs can
be reused as-is. This is an issue as their destructor was removed in
skb_gro_receive_list but not the reference to their socket, and then
they can't be orphaned. Fix this by also removing the reference to the
socket.

For example this could be observed,

  kernel BUG at include/linux/skbuff.h:3131!  (skb_orphan)
  RIP: 0010:ip6_rcv_core+0x11bc/0x19a0
  Call Trace:
   ipv6_list_rcv+0x250/0x3f0
   __netif_receive_skb_list_core+0x49d/0x8f0
   netif_receive_skb_list_internal+0x634/0xd40
   napi_complete_done+0x1d2/0x7d0
   gro_cell_poll+0x118/0x1f0

A similar construction is found in skb_gro_receive, apply the same
change there.

Fixes: 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb carring sock reference")
Signed-off-by: Antoine Tenart <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/core/gro.c
net/ipv4/udp_offload.c
This page took 0.069588 seconds and 4 git commands to generate.