]> Git Repo - linux.git/commit - kernel/sched.c
sched: Drop the need_resched() loop from cond_resched()
authorFrederic Weisbecker <[email protected]>
Thu, 16 Jul 2009 13:44:29 +0000 (15:44 +0200)
committerIngo Molnar <[email protected]>
Sat, 18 Jul 2009 13:51:38 +0000 (15:51 +0200)
commite7aaaa6934636d7a6cadd9e2a05250fbb6a34f65
tree8eabe708f83346910eb9a6c539d85d7b8f29b396
parent5304d5fc74a269cc6c3e70f9713684ca729abdf0
sched: Drop the need_resched() loop from cond_resched()

The schedule() function is a loop that reschedules the current
task while the TIF_NEED_RESCHED flag is set:

void schedule(void)
{
need_resched:
/* schedule code */
if (need_resched())
goto need_resched;
}

And cond_resched() repeat this loop:

do {
add_preempt_count(PREEMPT_ACTIVE);
schedule();
sub_preempt_count(PREEMPT_ACTIVE);
} while(need_resched());

This loop is needless because schedule() already did the check
and nothing can set TIF_NEED_RESCHED between schedule() exit
and the loop check in need_resched().

Then remove this needless loop.

Signed-off-by: Frederic Weisbecker <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
LKML-Reference: <1247725694[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
kernel/sched.c
This page took 0.053538 seconds and 4 git commands to generate.