]> Git Repo - linux.git/commit
kmemleak-test: drop __init to get better backtrace
authorJim Cromie <[email protected]>
Thu, 25 May 2023 17:43:56 +0000 (11:43 -0600)
committerAndrew Morton <[email protected]>
Fri, 9 Jun 2023 23:25:40 +0000 (16:25 -0700)
commitdcb8cbb58a218c99aab0dbf3f76cf06a04d44f37
treeed369bed995258a6e9344ced6a4c5ca4e961cc4e
parentd7f1afd0e3ac4c5c703b67d6003b62f760e95ba8
kmemleak-test: drop __init to get better backtrace

Drop the __init on kmemleak_test_init().  With it, the storage is
reclaimed, but then the symbol isn't available for "%pS" rendering,
and the backtrace gets a bare pointer where the actual leak happened.

unreferenced object 0xffff88800a2b0800 (size 1024):
  comm "modprobe", pid 413, jiffies 4294953430
  hex dump (first 32 bytes):
    73 02 00 00 75 01 00 68 02 00 00 01 00 00 00 04  s...u..h........
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000fabad728>] kmalloc_trace+0x26/0x90
    [<00000000ef738764>] 0xffffffffc02350a2
    [<00000000004e5795>] do_one_initcall+0x43/0x210
    [<00000000d768905e>] do_init_module+0x4a/0x210
    [<0000000087135ab5>] __do_sys_finit_module+0x93/0xf0
    [<000000004fcb1fa2>] do_syscall_64+0x34/0x80
    [<00000000c73c8d9d>] entry_SYSCALL_64_after_hwframe+0x46/0xb0

with __init gone, that trace entry renders like:

    [<00000000ef738764>] kmemleak_test_init+<offset>/<size>

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Jim Cromie <[email protected]>
Acked-by: Catalin Marinas <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
samples/kmemleak/kmemleak-test.c
This page took 0.055722 seconds and 4 git commands to generate.