]> Git Repo - linux.git/commit
serial: altera_uart: drop low-latency workaround
authorJohan Hovold <[email protected]>
Wed, 21 Apr 2021 09:54:46 +0000 (11:54 +0200)
committerGreg Kroah-Hartman <[email protected]>
Thu, 22 Apr 2021 10:09:24 +0000 (12:09 +0200)
commitd26595d188e6f1f0dc2e3e9591ef31492b4f64da
tree09621f1582e0c6793796bcbae3af4294ce33ee92
parentf22dd43fc16671c7c1237e855dfb65b5f73cc0eb
serial: altera_uart: drop low-latency workaround

Commit dd085ed8ef6c ("tty: serial: altera: drop uart_port->lock before
calling tty_flip_buffer_push()") claimed to address a locking
issue but only provided a dubious lockdep splat from an unrelated
driver, which in the end turned out to be due a broken local change
carried by the author.

Unfortunately these patches were merged before the issue had been
analysed properly so the commit messages makes no sense whatsoever.

The real issue was first seen on RT which at the time effectively always
set the low_latency flag for all serial drivers by patching
tty_flip_buffer_push(). This in turn revealed that many drivers did not
handle the infamous low_latency behaviour which meant that data was
pushed immediately to the line discipline instead of being deferred to a
work queue.

Since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"),
tty_flip_buffer_push() always schedules a work item to push data to the
line discipline and there's no need to keep any low_latency hacks
around.

Link: https://lore.kernel.org/linux-serial/[email protected]/
Cc: Tobias Klauser <[email protected]>
Acked-by: Tobias Klauser <[email protected]>
Signed-off-by: Johan Hovold <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
drivers/tty/serial/altera_uart.c
This page took 0.04951 seconds and 4 git commands to generate.