]> Git Repo - linux.git/commit
af_unix: fix garbage collect vs MSG_PEEK
authorMiklos Szeredi <[email protected]>
Wed, 28 Jul 2021 12:47:20 +0000 (14:47 +0200)
committerLinus Torvalds <[email protected]>
Wed, 28 Jul 2021 17:18:00 +0000 (10:18 -0700)
commitcbcf01128d0a92e131bd09f1688fe032480b65ca
tree9671f98e796537f07cac82a38527183d11a6f0c0
parent7d549995d4e0d99b68e8a7793a0d23da6fc40fe8
af_unix: fix garbage collect vs MSG_PEEK

unix_gc() assumes that candidate sockets can never gain an external
reference (i.e.  be installed into an fd) while the unix_gc_lock is
held.  Except for MSG_PEEK this is guaranteed by modifying inflight
count under the unix_gc_lock.

MSG_PEEK does not touch any variable protected by unix_gc_lock (file
count is not), yet it needs to be serialized with garbage collection.
Do this by locking/unlocking unix_gc_lock:

 1) increment file count

 2) lock/unlock barrier to make sure incremented file count is visible
    to garbage collection

 3) install file into fd

This is a lock barrier (unlike smp_mb()) that ensures that garbage
collection is run completely before or completely after the barrier.

Cc: <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Miklos Szeredi <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
net/unix/af_unix.c
This page took 0.055312 seconds and 4 git commands to generate.