]> Git Repo - linux.git/commit - kernel/delayacct.c
delayacct: Account blkio completion on the correct task
authorJosh Snyder <[email protected]>
Mon, 18 Dec 2017 16:15:10 +0000 (16:15 +0000)
committerIngo Molnar <[email protected]>
Tue, 16 Jan 2018 02:29:36 +0000 (03:29 +0100)
commitc96f5471ce7d2aefd0dda560cc23f08ab00bc65d
tree84feeca0e7b0819b55216e1fea50a3e0e79d445b
parenta8750ddca918032d6349adbf9a4b6555e7db20da
delayacct: Account blkio completion on the correct task

Before commit:

  e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler")

delayacct_blkio_end() was called after context-switching into the task which
completed I/O.

This resulted in double counting: the task would account a delay both waiting
for I/O and for time spent in the runqueue.

With e33a9bba85a8, delayacct_blkio_end() is called by try_to_wake_up().
In ttwu, we have not yet context-switched. This is more correct, in that
the delay accounting ends when the I/O is complete.

But delayacct_blkio_end() relies on 'get_current()', and we have not yet
context-switched into the task whose I/O completed. This results in the
wrong task having its delay accounting statistics updated.

Instead of doing that, pass the task_struct being woken to delayacct_blkio_end(),
so that it can update the statistics of the correct task.

Signed-off-by: Josh Snyder <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Acked-by: Balbir Singh <[email protected]>
Cc: <[email protected]>
Cc: Brendan Gregg <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Fixes: e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
include/linux/delayacct.h
kernel/delayacct.c
kernel/sched/core.c
This page took 0.045498 seconds and 4 git commands to generate.