]> Git Repo - linux.git/commit
mm/hugetlb: fix missing hugetlb_lock for resv uncharge
authorPeter Xu <[email protected]>
Wed, 17 Apr 2024 21:18:35 +0000 (17:18 -0400)
committerAndrew Morton <[email protected]>
Thu, 25 Apr 2024 02:34:25 +0000 (19:34 -0700)
commitb76b46902c2d0395488c8412e1116c2486cdfcb2
tree2cac9e74a99592a3f3cea9edbf891d88bcd31331
parent6db7412c142006985a15765785cf6c0c0dd75374
mm/hugetlb: fix missing hugetlb_lock for resv uncharge

There is a recent report on UFFDIO_COPY over hugetlb:

https://lore.kernel.org/all/000000000000ee06de0616177560@google.com/

350: lockdep_assert_held(&hugetlb_lock);

Should be an issue in hugetlb but triggered in an userfault context, where
it goes into the unlikely path where two threads modifying the resv map
together.  Mike has a fix in that path for resv uncharge but it looks like
the locking criteria was overlooked: hugetlb_cgroup_uncharge_folio_rsvd()
will update the cgroup pointer, so it requires to be called with the lock
held.

Link: https://lkml.kernel.org/r/[email protected]
Fixes: 79aa925bf239 ("hugetlb_cgroup: fix reservation accounting")
Signed-off-by: Peter Xu <[email protected]>
Reported-by: [email protected]
Reviewed-by: Mina Almasry <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
mm/hugetlb.c
This page took 0.055656 seconds and 4 git commands to generate.