]> Git Repo - linux.git/commit
drm: msm: Check cmd_db_read_aux_data() for failure
authorStephen Boyd <[email protected]>
Thu, 29 Nov 2018 16:38:26 +0000 (08:38 -0800)
committerAndy Gross <[email protected]>
Thu, 29 Nov 2018 23:41:53 +0000 (17:41 -0600)
commitb601f73130a375c912d9f2ec93c5f3cea5d6a3da
tree567a9421a41e1c9705adf1f4dc9fe20d196dcf7f
parentb7e386177fa53c3d704754095bd81189ef43bce4
drm: msm: Check cmd_db_read_aux_data() for failure

We need to check the call to cmd_db_read_aux_data() for the error case,
so that we don't continue and use potentially uninitialized values for
'pri_count' and 'sec_count'. Otherwise, we get the following compiler
warnings:

   drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.isra.12':
   drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
     pri_count >>= 1;
               ^~~
   drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function
[-Wmaybe-uninitialized]
     sec_count >>= 1;
               ^~~

Reported-by: Stephen Rothwell <[email protected]>
Reported-by: kbuild test robot <[email protected]>
Cc: Jordan Crouse <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Evan Green <[email protected]>
Cc: Jordan Crouse <[email protected]>
Cc: Rob Clark <[email protected]>
Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
Signed-off-by: Stephen Boyd <[email protected]>
Reviewed-by: Andy Gross <[email protected]>
Acked-by: Rob Clark <[email protected]>
Signed-off-by: Andy Gross <[email protected]>
drivers/gpu/drm/msm/adreno/a6xx_gmu.c
This page took 0.059609 seconds and 4 git commands to generate.