]> Git Repo - linux.git/commit - fs/nfsd/vfs.c
[PATCH] knfsd: nfsd4: fix acl xattr length return
authorNeilBrown <[email protected]>
Tue, 11 Apr 2006 05:55:26 +0000 (22:55 -0700)
committerLinus Torvalds <[email protected]>
Tue, 11 Apr 2006 13:18:51 +0000 (06:18 -0700)
commitb5872b0dcc0501035d5ae53c60f8cbbb3798da8a
tree8f0baf4103c0e5b5b97eea35cc9f416fdedd86cf
parentb905b7b0a054d2ab3e0c9304def998546c93f6b5
[PATCH] knfsd: nfsd4: fix acl xattr length return

We should be using the length from the second vfs_getxattr, in case it
changed.  (Note: there's still a small race here; we could end up returning
-ENOMEM if the length increased between the first and second call.  I don't
know whether it's worth spending a lot of effort to fix that.)

This makes XFS ACLs usable on NFS exports, which they currently aren't, since
XFS appears to be returning a too-large value for vfs_getxattr() when it's
passed a NULL buffer.  So there's probably an XFS bug here too, though since
getxattr with a NULL buffer is usually used to decide how much memory to
allocate, it may be a fairly harmless bug in most cases.

Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Neil Brown <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/nfsd/vfs.c
This page took 0.05139 seconds and 4 git commands to generate.