]> Git Repo - linux.git/commit - include/linux/swap.h
mm: remove gfp_mask from add_to_swap
authorHugh Dickins <[email protected]>
Tue, 6 Jan 2009 22:39:39 +0000 (14:39 -0800)
committerLinus Torvalds <[email protected]>
Tue, 6 Jan 2009 23:59:04 +0000 (15:59 -0800)
commitac47b003d03c2a4f28aef1d505b66d24ad191c4f
tree12c31491b756f4dc7a55a9e11b69b193743ff647
parent63d6c5ad7fc27455ce5cb4706884671fb7e0df08
mm: remove gfp_mask from add_to_swap

Remove gfp_mask argument from add_to_swap(): it's misleading because its
only caller, shrink_page_list(), is not atomic at that point; and in due
course (implementing discard) we'll sometimes want to allocate some memory
with GFP_NOIO (as is used in swap_writepage) when allocating swap.

No change to the gfp_mask passed down to add_to_swap_cache(): still use
__GFP_HIGH without __GFP_WAIT (with nomemalloc and nowarn as before):
though it's not obvious if that's the best combination to ask for here.

Signed-off-by: Hugh Dickins <[email protected]>
Cc: Lee Schermerhorn <[email protected]>
Cc: Rik van Riel <[email protected]>
Cc: Nick Piggin <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Cc: Robin Holt <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
include/linux/swap.h
mm/swap_state.c
mm/vmscan.c
This page took 0.049045 seconds and 4 git commands to generate.