]> Git Repo - linux.git/commit
rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()
authorPaul E. McKenney <[email protected]>
Thu, 21 May 2020 20:05:15 +0000 (22:05 +0200)
committerIngo Molnar <[email protected]>
Tue, 26 May 2020 17:04:18 +0000 (19:04 +0200)
commitaaf2bc50df1f4bfc6857fc601fc7b21d5a18c6a1
treef692b24126d8121a4a311e708a04110102b7f84d
parentb1fcf9b83c4149c63d1e0c699e85f93cbe28e211
rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()

There will likely be exception handlers that can sleep, which rules
out the usual approach of invoking rcu_nmi_enter() on entry and also
rcu_nmi_exit() on all exit paths.  However, the alternative approach of
just not calling anything can prevent RCU from coaxing quiescent states
from nohz_full CPUs that are looping in the kernel:  RCU must instead
IPI them explicitly.  It would be better to enable the scheduler tick
on such CPUs to interact with RCU in a lighter-weight manner, and this
enabling is one of the things that rcu_nmi_enter() currently does.

What is needed is something that helps RCU coax quiescent states while
not preventing subsequent sleeps.  This commit therefore splits out the
nohz_full scheduler-tick enabling from the rest of the rcu_nmi_enter()
logic into a new function named rcu_irq_enter_check_tick().

[ tglx: Renamed the function and made it a nop when context tracking is off ]
[ mingo: Fixed a CONFIG_NO_HZ_FULL assumption, harmonized and fixed all the
         comment blocks and cleaned up rcu_nmi_enter()/exit() definitions. ]

Suggested-by: Andy Lutomirski <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
include/linux/hardirq.h
kernel/rcu/tree.c
This page took 0.061216 seconds and 4 git commands to generate.