]> Git Repo - linux.git/commit
agp: ensure GART has an address before enabling it
authorStephen Kitt <[email protected]>
Mon, 31 Jan 2011 22:25:43 +0000 (14:25 -0800)
committerDave Airlie <[email protected]>
Thu, 3 Feb 2011 23:43:57 +0000 (09:43 +1000)
commita70b95c017e8b518e1e069853355e4e497453dbb
treec4264dc861b449f83fc40d9fb942083c5d985870
parentcecd1455bc9cbd9568036f502ee8ded0a64354a7
agp: ensure GART has an address before enabling it

Some BIOSs (eg.  the AMI BIOS on the Asus P4P800 motherboard) don't
initialise the GART address, and pcibios_assign_resources() can ignore it
because it can be marked as a host bridge (see
https://bugzilla.kernel.org/show_bug.cgi?id=24392#c5 for details).  This
was handled correctly up to 2.6.35, but the pci_enable_device() cleanup in
2.6.36 96576a9e1a0cdb8 ("agp: intel-agp: do not use PCI resources before
pci_enable_device()") means that the kernel tries to enable the GART
before assigning it an address; in such cases the GART overlaps with other
device assignments and ends up being disabled.

This patch fixes https://bugzilla.kernel.org/show_bug.cgi?id=24392

Note that I imagine efficeon-agp.c probably has the same problem, but
I can't test that and I'd like to make sure this patch is suitable for
-stable (since 2.6.36 and 2.6.37 are affected).

Signed-off-by: Stephen Kitt <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: Maciej Rutecki <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Kulikov Vasiliy <[email protected]>
Cc: Florian Mickler <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>
drivers/char/agp/intel-agp.c
This page took 0.050402 seconds and 4 git commands to generate.