]> Git Repo - linux.git/commit
usb: gadget: f_rndis: Avoid to use ERROR macro if cdev can be null
authorTruls Bengtsson <[email protected]>
Wed, 20 Mar 2013 13:02:25 +0000 (14:02 +0100)
committerFelipe Balbi <[email protected]>
Wed, 20 Mar 2013 15:30:51 +0000 (17:30 +0200)
commit967baed40eaaf6df632b7e929b903140a9744b87
tree84a51e839611404688adc31a26091d73e90169a4
parent7fa4cd1a78ea5af688ffce45553abbee9d7afd84
usb: gadget: f_rndis: Avoid to use ERROR macro if cdev can be null

The udc_irq service runs the isr_tr_complete_handler which in turn
"nukes" the endpoints, including a call to rndis_response_complete,
if appropriate. If the rndis_msg_parser fails here, an error will
be printed using a dev_err call (through the ERROR() macro).

However, if the usb cable was just disconnected the device (cdev)
might not be available and will be null. Since the dev_err macro will
dereference the cdev pointer we get a null pointer exception.

Reviewed-by: Radovan Lekanovic <[email protected]>
Signed-off-by: Truls Bengtsson <[email protected]>
Signed-off-by: Oskar Andero <[email protected]>
Acked-by: Michal Nazarewicz <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
drivers/usb/gadget/f_rndis.c
This page took 0.054323 seconds and 4 git commands to generate.