]> Git Repo - linux.git/commit
ynl: samples: fix recycling rate calculation
authorJakub Kicinski <[email protected]>
Thu, 7 Mar 2024 22:11:22 +0000 (14:11 -0800)
committerDavid S. Miller <[email protected]>
Mon, 11 Mar 2024 10:22:06 +0000 (10:22 +0000)
commit900b2801bf250affe410193a0d27a2ba9f2db4e5
treedf32412674788b5595094763d5d633a30e67cc23
parent08842c43d0165b0ed78907fd8cc92ce17d857913
ynl: samples: fix recycling rate calculation

Running the page-pool sample on production machines under moderate
networking load shows recycling rate higher than 100%:

$ page-pool
    eth0[2] page pools: 14 (zombies: 0)
refs: 89088 bytes: 364904448 (refs: 0 bytes: 0)
recycling: 100.3% (alloc: 1392:2290247724 recycle: 469289484:1828235386)

Note that outstanding refs (89088) == slow alloc * cache size (1392 * 64)
which means this machine is recycling page pool pages perfectly, not
a single page has been released.

The extra 0.3% is because sample ignores allocations from the ptr_ring.
Treat those the same as alloc_fast, the ring vs cache alloc is
already captured accurately enough by recycling stats.

With the fix:

$ page-pool
    eth0[2] page pools: 14 (zombies: 0)
refs: 89088 bytes: 364904448 (refs: 0 bytes: 0)
recycling: 100.0% (alloc: 1392:2331141604 recycle: 473625579:1857460661)

Signed-off-by: Jakub Kicinski <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
tools/net/ynl/samples/page-pool.c
This page took 0.05247 seconds and 4 git commands to generate.