]> Git Repo - linux.git/commit - drivers/ntb/ntb_transport.c
ntb_transport: fix bug calculating num_qps_mw
authorLogan Gunthorpe <[email protected]>
Mon, 5 Jun 2017 20:00:53 +0000 (14:00 -0600)
committerJon Mason <[email protected]>
Mon, 19 Jun 2017 18:24:41 +0000 (14:24 -0400)
commit8e8496e0e9564b66165f5219a4e8ed20b0d3fc6b
tree13e3ec29ae0b69a45fca5021525024b2b7c5da9b
parentcb827ee6ccc3e480f0d9c0e8e53eef55be5b0414
ntb_transport: fix bug calculating num_qps_mw

A divide by zero error occurs if qp_count is less than mw_count because
num_qps_mw is calculated to be zero. The calculation appears to be
incorrect.

The requirement is for num_qps_mw to be set to qp_count / mw_count
with any remainder divided among the earlier mws.

For example, if mw_count is 5 and qp_count is 12 then mws 0 and 1
will have 3 qps per window and mws 2 through 4 will have 2 qps per window.
Thus, when mw_num < qp_count % mw_count, num_qps_mw is 1 higher
than when mw_num >= qp_count.

Signed-off-by: Logan Gunthorpe <[email protected]>
Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Acked-by: Allen Hubbe <[email protected]>
Signed-off-by: Jon Mason <[email protected]>
drivers/ntb/ntb_transport.c
This page took 0.051756 seconds and 4 git commands to generate.