]> Git Repo - linux.git/commit
perf diff: Fix segfault on 'perf diff -o N' option
authorNamhyung Kim <[email protected]>
Wed, 18 Jan 2017 05:14:56 +0000 (14:14 +0900)
committerArnaldo Carvalho de Melo <[email protected]>
Thu, 2 Feb 2017 14:39:04 +0000 (11:39 -0300)
commit8381cdd0e32dd748bd34ca3ace476949948bd793
tree10521265c230c18b407c0e4ffdecd528a16f072c
parentfff4b87e594ad3d2e4f51e8d3d86a6f9d3d8b654
perf diff: Fix segfault on 'perf diff -o N' option

The -o/--order option is to select column number to sort a diff result.

It does the job by adding a hpp field at the beginning of the sort list.
But it should not be added to the output field list as it has no
callbacks required by a output field.

During the setup_sorting(), the perf_hpp__setup_output_field() appends
the given sort keys to the output field if it's not there already.

Originally it was checked by fmt->list being non-empty.  But commit
3f931f2c4274 ("perf hists: Make hpp setup function generic") changed it
to check the ->equal callback.

Anyways, we don't need to add the pseudo hpp field to the output field
list since it won't be used for output.  So just skip fields if they
have no ->color or ->entry callbacks.

Signed-off-by: Namhyung Kim <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Fixes: 3f931f2c4274 ("perf hists: Make hpp setup function generic")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
tools/perf/ui/hist.c
This page took 0.056697 seconds and 4 git commands to generate.