]> Git Repo - linux.git/commit
rcuscale: Do a proper cleanup if kfree_scale_init() fails
authorUladzislau Rezki (Sony) <[email protected]>
Wed, 13 Nov 2024 11:00:08 +0000 (12:00 +0100)
committerFrederic Weisbecker <[email protected]>
Fri, 15 Nov 2024 21:23:50 +0000 (22:23 +0100)
commit812a1c3b9f7c36d9255f0d29d0a3d324e2f52321
tree7c4e709316c88998e074416f84a013fb5d6d2bca
parent80e935c8c154d8fbdd85a20d89b4962662ceddd7
rcuscale: Do a proper cleanup if kfree_scale_init() fails

A static analyzer for C, Smatch, reports and triggers below
warnings:

   kernel/rcu/rcuscale.c:1215 rcu_scale_init()
   warn: inconsistent returns 'global &fullstop_mutex'.

The checker complains about, we do not unlock the "fullstop_mutex"
mutex, in case of hitting below error path:

<snip>
...
    if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
        pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");
        WARN_ON_ONCE(1);
        return -1;
        ^^^^^^^^^^
...
<snip>

it happens because "-1" is returned right away instead of
doing a proper unwinding.

Fix it by jumping to "unwind" label instead of returning -1.

Reported-by: Dan Carpenter <[email protected]>
Reviewed-by: Paul E. McKenney <[email protected]>
Reviewed-by: Neeraj Upadhyay <[email protected]>
Closes: https://lore.kernel.org/rcu/ZxfTrHuEGtgnOYWp@pc636/T/
Fixes: 084e04fff160 ("rcuscale: Add laziness and kfree tests")
Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
Signed-off-by: Frederic Weisbecker <[email protected]>
kernel/rcu/rcuscale.c
This page took 0.050757 seconds and 4 git commands to generate.