]> Git Repo - linux.git/commit
drivers, net, ppp: convert syncppp.refcnt from atomic_t to refcount_t
authorElena Reshetova <[email protected]>
Fri, 20 Oct 2017 07:23:48 +0000 (10:23 +0300)
committerDavid S. Miller <[email protected]>
Sun, 22 Oct 2017 01:22:39 +0000 (02:22 +0100)
commit709c89b45b874b2f81a074b8802a736009873f48
tree80ef98e8c9744487746d29eb1313d39762a08ac8
parentd780cd44e3cea119a3346e6d7c04d35b9c50d54b
drivers, net, ppp: convert syncppp.refcnt from atomic_t to refcount_t

atomic_t variables are currently used to implement reference
counters with the following properties:
 - counter is initialized to 1 using atomic_set()
 - a resource is freed upon counter reaching zero
 - once counter reaches zero, its further
   increments aren't allowed
 - counter schema uses basic atomic operations
   (set, inc, inc_not_zero, dec_and_test, etc.)

Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.

The variable syncppp.refcnt is used as pure reference counter.
Convert it to refcount_t and fix up the operations.

Suggested-by: Kees Cook <[email protected]>
Reviewed-by: David Windsor <[email protected]>
Reviewed-by: Hans Liljestrand <[email protected]>
Signed-off-by: Elena Reshetova <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/ppp/ppp_synctty.c
This page took 0.055187 seconds and 4 git commands to generate.