]> Git Repo - linux.git/commit
m68k: amiflop - Get rid of sleep_on calls
authorAndreas Bombe <[email protected]>
Wed, 10 Dec 2008 01:02:19 +0000 (02:02 +0100)
committerGeert Uytterhoeven <[email protected]>
Mon, 12 Jan 2009 19:56:33 +0000 (20:56 +0100)
commit6d0be946e150ac17da7381b27fd40603ca40b58f
tree4795a77c5f43f44441aa7692e25a7ced6e73e0c1
parentdc8ee69c760317be0bb4eac2bd2fd81eb663627a
m68k: amiflop - Get rid of sleep_on calls

Apart from sleep_on() calls that could be easily converted to
wait_event() and completion calls amiflop also used a flag in ms_delay()
and ms_isr() as a custom mutex for ms_delay() without a need for
explicit unlocking.  I converted that to a standard mutex.

The replacement for the unconditional sleep_on() in fd_motor_on() is a
complete_all() together with a INIT_COMPLETION() before the mod_timer()
call.  It appears to me that fd_motor_on() might be called concurrently
and fd_select() does not guarantee mutual exclusivity in the case the
same drive gets selected again.

Signed-off-by: Andreas Bombe <[email protected]>
Acked-by: Jörg Dorchain <[email protected]>
Signed-off-by: Geert Uytterhoeven <[email protected]>
drivers/block/amiflop.c
This page took 0.053797 seconds and 4 git commands to generate.