]> Git Repo - linux.git/commit
mm: zswap: fix shrinker NULL crash with cgroup_disable=memory
authorJohannes Weiner <[email protected]>
Thu, 18 Apr 2024 12:26:28 +0000 (08:26 -0400)
committerAndrew Morton <[email protected]>
Thu, 25 Apr 2024 02:34:26 +0000 (19:34 -0700)
commit682886ec69d22363819a83ddddd5d66cb5c791e1
tree94594803c09620a99b5a964ab42d276d03a3f39b
parentd99e3140a4d33e26066183ff727d8f02f56bec64
mm: zswap: fix shrinker NULL crash with cgroup_disable=memory

Christian reports a NULL deref in zswap that he bisected down to the zswap
shrinker.  The issue also cropped up in the bug trackers of libguestfs [1]
and the Red Hat bugzilla [2].

The problem is that when memcg is disabled with the boot time flag, the
zswap shrinker might get called with sc->memcg == NULL.  This is okay in
many places, like the lruvec operations.  But it crashes in
memcg_page_state() - which is only used due to the non-node accounting of
cgroup's the zswap memory to begin with.

Nhat spotted that the memcg can be NULL in the memcg-disabled case, and I
was then able to reproduce the crash locally as well.

[1] https://github.com/libguestfs/libguestfs/issues/139
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2275252

Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Fixes: b5ba474f3f51 ("zswap: shrink zswap pool based on memory pressure")
Signed-off-by: Johannes Weiner <[email protected]>
Reported-by: Christian Heusel <[email protected]>
Debugged-by: Nhat Pham <[email protected]>
Suggested-by: Nhat Pham <[email protected]>
Tested-by: Christian Heusel <[email protected]>
Acked-by: Yosry Ahmed <[email protected]>
Cc: Chengming Zhou <[email protected]>
Cc: Dan Streetman <[email protected]>
Cc: Richard W.M. Jones <[email protected]>
Cc: Seth Jennings <[email protected]>
Cc: Vitaly Wool <[email protected]>
Cc: <[email protected]> [v6.8]
Signed-off-by: Andrew Morton <[email protected]>
mm/zswap.c
This page took 0.045425 seconds and 4 git commands to generate.