]> Git Repo - linux.git/commit - include/trace/events/sched.h
tracing, sched, vfs: Fix 'old_pid' usage in trace_sched_process_exec()
authorOleg Nesterov <[email protected]>
Fri, 30 Mar 2012 16:26:36 +0000 (18:26 +0200)
committerIngo Molnar <[email protected]>
Sat, 31 Mar 2012 09:53:22 +0000 (11:53 +0200)
commit6308191f6f55d3629c7dbe72dfb856ad9fa560fd
treed3f073b0e522fc7dbee52ca6c25d92f28059f2fd
parent8ebfdf2babcda5a3b06cc67523bca1f9aed46009
tracing, sched, vfs: Fix 'old_pid' usage in trace_sched_process_exec()

1. TRACE_EVENT(sched_process_exec) forgets to actually use the
   old pid argument, it sets ->old_pid = p->pid.

2. search_binary_handler() uses the wrong pid number. tracepoint
   needs the global pid_t from the root namespace, while old_pid
   is the virtual pid number as it seen by the tracer/parent.

With this patch we have two pid_t's in search_binary_handler(),
not really nice. Perhaps we should switch to "struct pid*", but
in this case it would be better to cleanup the current code
first and move the "depth == 0" code outside.

Signed-off-by: Oleg Nesterov <[email protected]>
Cc: David Smith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Denys Vlasenko <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
fs/exec.c
include/trace/events/sched.h
This page took 0.054614 seconds and 4 git commands to generate.