]> Git Repo - linux.git/commit
nfs: fix xattr inode op pointers when disabled
authorChristoph Hellwig <[email protected]>
Thu, 30 Jan 2014 14:01:52 +0000 (06:01 -0800)
committerLinus Torvalds <[email protected]>
Thu, 30 Jan 2014 17:37:49 +0000 (09:37 -0800)
commit5f13ee9c1ce87b3c99928ab33ef43a2c0d3fd220
tree4f40ff795f8e23212f0a93f0ebf8345c34347edb
parent9b0cd304f26b9fca140de15deeac2bf357d1f388
nfs: fix xattr inode op pointers when disabled

Chris Mason reported a NULL pointer derefernence in generic_getxattr()
that was due to sb->s_xattr being NULL.

The reason is that the nfs #ifdef's for ACL support were misplaced, and
the nfs3 inode operations had the xattr operation pointers set up, even
though xattrs were not actually supported.  As a result, the xattr code
was being called without the infrastructure having been set up.

Move the #ifdef's appropriately.

Reported-and-tested-by: Chris Mason <[email protected]>
Acked-by: Al Viro [email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/nfs/nfs3proc.c
This page took 0.055024 seconds and 4 git commands to generate.