]> Git Repo - linux.git/commit
drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init
authorMatthew Brost <[email protected]>
Wed, 24 Jul 2024 15:28:31 +0000 (08:28 -0700)
committerMatthew Brost <[email protected]>
Fri, 9 Aug 2024 20:11:01 +0000 (13:11 -0700)
commit549dd786b61cd3db903f5d94d07fc5a89ccdbeb9
tree662705d9e200ebe58b627fe2d6a00cb6ef3e6237
parent5bdacb0907c1f531995b6ba47b832ac3a0182ae9
drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init

The critical section which requires the VM dma-resv is the call
xe_lrc_create in __xe_exec_queue_init. Move this lock to
__xe_exec_queue_init holding it just around xe_lrc_create. Not only is
good practice, this also fixes a locking double of the VM dma-resv in
the error paths of __xe_exec_queue_init as xe_lrc_put tries to acquire
this too resulting in a deadlock.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Maarten Lankhorst <[email protected]>
Signed-off-by: Matthew Brost <[email protected]>
Reviewed-by: Maarten Lankhorst <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/xe/xe_exec_queue.c
This page took 0.056901 seconds and 4 git commands to generate.