]> Git Repo - linux.git/commit
SCSI: fix regression in scsi_send_eh_cmnd()
authorAlan Stern <[email protected]>
Fri, 21 Nov 2014 15:44:49 +0000 (10:44 -0500)
committerJames Bottomley <[email protected]>
Tue, 30 Dec 2014 16:59:13 +0000 (08:59 -0800)
commit511833acfc06c013d453e288f483c682c60ffbff
treeda40df4eadfaf3fda5b0eb0fd1b031c278e45a73
parentefc7a288382cffc76d6cdb9678f643db37991906
SCSI: fix regression in scsi_send_eh_cmnd()

Commit ac61d1955934 (scsi: set correct completion code in
scsi_send_eh_cmnd()) introduced a bug.  It changed the stored return
value from a queuecommand call, but it didn't take into account that
the return value was used again later on.  This patch fixes the bug by
changing the later usage.

There is a big comment in the middle of scsi_send_eh_cmnd() which
does a good job of explaining how the routine works.  But it mentions
a "rtn = FAILURE" value that doesn't exist in the code.  This patch
adjusts the code to match the comment (I assume the comment is right
and the code is wrong).

This fixes Bugzilla #88341.

Signed-off-by: Alan Stern <[email protected]>
Reported-by: Андрей Аладьев <[email protected]>
Tested-by: Андрей Аладьев <[email protected]>
Fixes: ac61d19559349e205dad7b5122b281419aa74a82
Acked-by: Hannes Reinecke <[email protected]>
Cc: <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
drivers/scsi/scsi_error.c
This page took 0.050542 seconds and 4 git commands to generate.