]> Git Repo - linux.git/commit
mei: nfc: fix deadlock on shutdown/suspend path
authorTomas Winkler <[email protected]>
Tue, 7 Jul 2015 21:22:03 +0000 (00:22 +0300)
committerLinus Torvalds <[email protected]>
Tue, 7 Jul 2015 22:04:12 +0000 (15:04 -0700)
commit4f273959b850569253299987eee611927f048de7
tree384abc27b134c3570ad8bcc7b6461e4128e7ed6a
parentc7e9ad7da219cf3f8a7cc45eb1c02fdd91199e8d
mei: nfc: fix deadlock on shutdown/suspend path

In function mei_nfc_host_exit mei_cl_remove_device cannot be called
under the device mutex as device removing flow invokes the device driver
remove handler that calls in turn to mei_cl_disable_device which
naturally acquires the device mutex.

Also remove mei_cl_bus_remove_devices which has the same issue, but is
never executed as currently the only device on the mei client bus is NFC
and a new device cannot be easily added till the bus revamp is
completed.

This fixes regression caused by commit be9b720a0ccb ("mei_phy: move all
nfc logic from mei driver to nfc")

Prior to this change the nfc driver remove handler called to no-op
disable function while actual nfc device was disabled directly from the
mei driver.

Reported-by: Linus Torvalds <[email protected]>
Acked-by: Greg Kroah-Hartman <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
drivers/misc/mei/bus.c
drivers/misc/mei/init.c
drivers/misc/mei/nfc.c
This page took 0.053562 seconds and 4 git commands to generate.