]> Git Repo - linux.git/commit
genirq/PM: Restore system wake up from chained interrupts
authorGrygorii Strashko <[email protected]>
Tue, 10 Nov 2015 09:58:12 +0000 (11:58 +0200)
committerThomas Gleixner <[email protected]>
Tue, 10 Nov 2015 14:11:31 +0000 (09:11 -0500)
commit4717f133736dec10605da9e29e707144c8d486df
tree183a0d10e42d7bbcdc36fa93041c82e11e6f7097
parent66ef3493d4bb387f5a83915e33dc893102fd1b43
genirq/PM: Restore system wake up from chained interrupts

Commit e509bd7da149 ("genirq: Allow migration of chained interrupts
by installing default action") breaks PCS wake up IRQ behaviour on
TI OMAP based platforms (dra7-evm).

TI OMAP IRQ wake up configuration:
GIC-irqchip->PCM_IRQ
  |- omap_prcm_register_chain_handler
     |- PRCM-irqchip -> PRCM_IO_IRQ
        |- pcs_irq_chain_handler
           |- pinctrl-irqchip -> PCS_uart1_wakeup_irq

This happens because IRQ PM code (irq/pm.c) is expected to ignore
chained interrupts by default:
  static bool suspend_device_irq(struct irq_desc *desc)
  {
if (!desc->action || desc->no_suspend_depth)
return false;
 - it's expected !desc->action = true for chained interrupts;

but, after above change, all chained interrupt descriptors will
have default action handler installed - chained_action.
As result, chained interrupts will be silently disabled during system
suspend.

Hence, fix it by introducing helper function irq_desc_is_chained() and
use it in suspend_device_irq() for chained interrupts identification
and skip them, once detected.

Fixes: e509bd7da149 ("genirq: Allow migration of chained interrupts..")
Signed-off-by: Grygorii Strashko <[email protected]>
Reviewed-by: Mika Westerberg <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: Tony Lindgren <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
kernel/irq/internals.h
kernel/irq/pm.c
kernel/irq/proc.c
This page took 0.053278 seconds and 4 git commands to generate.