]> Git Repo - linux.git/commit
Revert: "dm-verity: restart or panic on an I/O error"
authorMikulas Patocka <[email protected]>
Wed, 2 Oct 2024 13:56:18 +0000 (15:56 +0200)
committerMikulas Patocka <[email protected]>
Wed, 2 Oct 2024 14:15:34 +0000 (16:15 +0200)
commit462763212dd71c41f092b48eaa352bc1f5ed5d66
tree413e959313df12898616280e48cc0f53617e6ea0
parent9852d85ec9d492ebef56dc5f229416c925758edc
Revert: "dm-verity: restart or panic on an I/O error"

This reverts commit e6a3531dd542cb127c8de32ab1e54a48ae19962b.

The problem that the commit e6a3531dd542cb127c8de32ab1e54a48ae19962b
fixes was reported as a security bug, but Google engineers working on
Android and ChromeOS didn't want to change the default behavior, they
want to get -EIO rather than restarting the system, so I am reverting
that commit.

Note also that calling machine_restart from the I/O handling code is
potentially unsafe (the reboot notifiers may wait for the bio that
triggered the restart), but Android uses the reboot notifiers to store
the reboot reason into the PMU microcontroller, so machine_restart must
be used.

Signed-off-by: Mikulas Patocka <[email protected]>
Cc: [email protected]
Fixes: e6a3531dd542 ("dm-verity: restart or panic on an I/O error")
Suggested-by: Sami Tolvanen <[email protected]>
Suggested-by: Will Drewry <[email protected]>
drivers/md/dm-verity-target.c
This page took 0.060526 seconds and 4 git commands to generate.