]> Git Repo - linux.git/commit
EDAC/versal: Convert to platform remove callback returning void
authorUwe Kleine-König <[email protected]>
Fri, 8 Mar 2024 08:51:06 +0000 (09:51 +0100)
committerBorislav Petkov (AMD) <[email protected]>
Fri, 8 Mar 2024 12:57:49 +0000 (13:57 +0100)
commit4527a2194e7c2f88e940f9071084daa307ce08af
tree70ae005a86e3b77ce101fd8a8da1abc608a1212c
parent83bf24051a60d867e7633e07343913593c242f5d
EDAC/versal: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve this, there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Reviewed-by: Shubhrajyoti Datta <[email protected]>
Link: https://lore.kernel.org/r/83deca1ce260f7e17ff3cb106c9a6946d4ca4505.1709886922.git.u.kleine-koenig@pengutronix.de
drivers/edac/versal_edac.c
This page took 0.055627 seconds and 4 git commands to generate.