]> Git Repo - linux.git/commit
include/linux/swapops.h: correct guards for non_swap_entry()
authorSteven Price <[email protected]>
Tue, 7 Apr 2020 03:08:43 +0000 (20:08 -0700)
committerLinus Torvalds <[email protected]>
Tue, 7 Apr 2020 17:43:41 +0000 (10:43 -0700)
commit3f3673d7d324d872d9d8ddb73b3e5e47fbf12e0d
treea47842c1923bef662142c16fdf2446af46f3bd10
parente4a9bc58969abc695a6ebb06d801a99c1bafc001
include/linux/swapops.h: correct guards for non_swap_entry()

If CONFIG_DEVICE_PRIVATE is defined, but neither CONFIG_MEMORY_FAILURE nor
CONFIG_MIGRATION, then non_swap_entry() will return 0, meaning that the
condition (non_swap_entry(entry) && is_device_private_entry(entry)) in
zap_pte_range() will never be true even if the entry is a device private
one.

Equally any other code depending on non_swap_entry() will not function as
expected.

I originally spotted this just by looking at the code, I haven't actually
observed any problems.

Looking a bit more closely it appears that actually this situation
(currently at least) cannot occur:

DEVICE_PRIVATE depends on ZONE_DEVICE
ZONE_DEVICE depends on MEMORY_HOTREMOVE
MEMORY_HOTREMOVE depends on MIGRATION

Fixes: 5042db43cc26 ("mm/ZONE_DEVICE: new type of ZONE_DEVICE for unaddressable memory")
Signed-off-by: Steven Price <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Cc: Jérôme Glisse <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: John Hubbard <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Linus Torvalds <[email protected]>
include/linux/swapops.h
This page took 0.055486 seconds and 4 git commands to generate.