]> Git Repo - linux.git/commit - io_uring/poll.c
io_uring: cmpxchg for poll arm refs release
authorPavel Begunkov <[email protected]>
Sun, 20 Nov 2022 16:57:41 +0000 (16:57 +0000)
committerJens Axboe <[email protected]>
Fri, 25 Nov 2022 13:54:16 +0000 (06:54 -0700)
commit2f3893437a4ebf2e892ca172e9e122841319d675
tree4d8c735da6a276bfe9613a346b40947c158c747f
parent7fdbc5f014c3f71bc44673a2d6c5bb2d12d45f25
io_uring: cmpxchg for poll arm refs release

Replace atomically substracting the ownership reference at the end of
arming a poll with a cmpxchg. We try to release ownership by setting 0
assuming that poll_refs didn't change while we were arming. If it did
change, we keep the ownership and use it to queue a tw, which is fully
capable to process all events and (even tolerates spurious wake ups).

It's a bit more elegant as we reduce races b/w setting the cancellation
flag and getting refs with this release, and with that we don't have to
worry about any kinds of underflows. It's not the fastest path for
polling. The performance difference b/w cmpxchg and atomic dec is
usually negligible and it's not the fastest path.

Cc: [email protected]
Fixes: aa43477b04025 ("io_uring: poll rework")
Signed-off-by: Pavel Begunkov <[email protected]>
Link: https://lore.kernel.org/r/0c95251624397ea6def568ff040cad2d7926fd51.1668963050.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <[email protected]>
io_uring/poll.c
This page took 0.053331 seconds and 4 git commands to generate.