]> Git Repo - linux.git/commit
blk-mq: move lockdep_assert_held() into elevator_exit
authorMing Lei <[email protected]>
Wed, 25 Sep 2019 22:23:54 +0000 (06:23 +0800)
committerJens Axboe <[email protected]>
Thu, 26 Sep 2019 06:45:05 +0000 (00:45 -0600)
commit284b94be1925dbe035ce5218d8b5c197321262c7
treecf92c78c0064fa7b31b0d03baf266a18ed21f5e7
parentf41def397161053eb0d3ed6861ef65985efbf293
blk-mq: move lockdep_assert_held() into elevator_exit

Commit c48dac137a62 ("block: don't hold q->sysfs_lock in elevator_init_mq")
removes q->sysfs_lock from elevator_init_mq(), but forgot to deal with
lockdep_assert_held() called in blk_mq_sched_free_requests() which is
run in failure path of elevator_init_mq().

blk_mq_sched_free_requests() is called in the following 3 functions:

elevator_init_mq()
elevator_exit()
blk_cleanup_queue()

In blk_cleanup_queue(), blk_mq_sched_free_requests() is followed exactly
by 'mutex_lock(&q->sysfs_lock)'.

So moving the lockdep_assert_held() from blk_mq_sched_free_requests()
into elevator_exit() for fixing the report by syzbot.

Reported-by: [email protected]
Fixed: c48dac137a62 ("block: don't hold q->sysfs_lock in elevator_init_mq")
Reviewed-by: Bart Van Assche <[email protected]>
Reviewed-by: Damien Le Moal <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
block/blk-mq-sched.c
block/blk.h
This page took 0.055944 seconds and 4 git commands to generate.