]> Git Repo - linux.git/commit
net: pcs: xpcs: propagate xpcs_read error to xpcs_get_state_c37_sgmii
authorVladimir Oltean <[email protected]>
Wed, 20 Jul 2022 11:20:57 +0000 (14:20 +0300)
committerJakub Kicinski <[email protected]>
Fri, 22 Jul 2022 02:01:16 +0000 (19:01 -0700)
commit27161db0904ee48e59140aa8d0835939a666c1f1
treedd6dda6fd2b01558a1df5e24a972e52ecc61ca8a
parent7ca433dc6dedb2ec98dfc943f6db0c9b8996ed11
net: pcs: xpcs: propagate xpcs_read error to xpcs_get_state_c37_sgmii

While phylink_pcs_ops :: pcs_get_state does return void, xpcs_get_state()
does check for a non-zero return code from xpcs_get_state_c37_sgmii()
and prints that as a message to the kernel log.

However, a non-zero return code from xpcs_read() is translated into
"return false" (i.e. zero as int) and the I/O error is therefore not
printed. Fix that.

Fixes: b97b5331b8ab ("net: pcs: add C37 SGMII AN support for intel mGbE controller")
Signed-off-by: Vladimir Oltean <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
drivers/net/pcs/pcs-xpcs.c
This page took 0.052475 seconds and 4 git commands to generate.