]> Git Repo - linux.git/commit
[TCP]: Do not use inet->id of global tcp_socket when sending RST.
authorAlexey Kuznetsov <[email protected]>
Wed, 22 Mar 2006 22:27:59 +0000 (14:27 -0800)
committerDavid S. Miller <[email protected]>
Wed, 22 Mar 2006 22:27:59 +0000 (14:27 -0800)
commit1a55d57b107c3e06935763905dc0fb235214569d
tree5d894dbda60fa2e998dda4912e6e0a50f769709d
parent6a534ee35cfd02f60e99d301b9ac446ea11a9cfd
[TCP]: Do not use inet->id of global tcp_socket when sending RST.

The problem is in ip_push_pending_frames(), which uses:

        if (!df) {
                __ip_select_ident(iph, &rt->u.dst, 0);
        } else {
                iph->id = htons(inet->id++);
        }

instead of ip_select_ident().

Right now I think the code is a nonsense. Most likely, I copied it from
old ip_build_xmit(), where it was really special, we had to decide
whether to generate unique ID when generating the first (well, the last)
fragment.

In ip_push_pending_frames() it does not make sense, it should use plain
ip_select_ident() instead.

Signed-off-by: Alexey Kuznetsov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/ipv4/ip_output.c
This page took 0.050992 seconds and 4 git commands to generate.