]> Git Repo - linux.git/commit
net: gso: fix tcp fraglist segmentation after pull from frag_list
authorFelix Fietkau <[email protected]>
Thu, 26 Sep 2024 08:53:14 +0000 (10:53 +0200)
committerJakub Kicinski <[email protected]>
Thu, 3 Oct 2024 00:21:47 +0000 (17:21 -0700)
commit17bd3bd82f9f79f3feba15476c2b2c95a9b11ff8
tree2a519575f05f2c31718d0b4a93222d01d4934dd3
parent854e9bf5c524c836e3c65737b9ddc90e8b7622cc
net: gso: fix tcp fraglist segmentation after pull from frag_list

Detect tcp gso fraglist skbs with corrupted geometry (see below) and
pass these to skb_segment instead of skb_segment_list, as the first
can segment them correctly.

Valid SKB_GSO_FRAGLIST skbs
- consist of two or more segments
- the head_skb holds the protocol headers plus first gso_size
- one or more frag_list skbs hold exactly one segment
- all but the last must be gso_size

Optional datapath hooks such as NAT and BPF (bpf_skb_pull_data) can
modify these skbs, breaking these invariants.

In extreme cases they pull all data into skb linear. For TCP, this
causes a NULL ptr deref in __tcpv4_gso_segment_list_csum at
tcp_hdr(seg->next).

Detect invalid geometry due to pull, by checking head_skb size.
Don't just drop, as this may blackhole a destination. Convert to be
able to pass to regular skb_segment.

Approach and description based on a patch by Willem de Bruijn.

Link: https://lore.kernel.org/netdev/[email protected]/
Link: https://lore.kernel.org/netdev/[email protected]/
Fixes: bee88cd5bd83 ("net: add support for segmenting TCP fraglist GSO packets")
Cc: [email protected]
Signed-off-by: Felix Fietkau <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
net/ipv4/tcp_offload.c
net/ipv6/tcpv6_offload.c
This page took 0.055738 seconds and 4 git commands to generate.