]> Git Repo - linux.git/commit
mm/readahead: fix large folio support in async readahead
authorYafang Shao <[email protected]>
Fri, 6 Dec 2024 08:30:25 +0000 (16:30 +0800)
committerAndrew Morton <[email protected]>
Tue, 31 Dec 2024 01:59:07 +0000 (17:59 -0800)
commit158cdce87c8c172787063998ad5dd3e2f658b963
treea838c78cc85851ad77ccc912c4ba7cd989a7d15c
parent34d7cf637c437d5c2a8a6ef23ea45193bad8a91c
mm/readahead: fix large folio support in async readahead

When testing large folio support with XFS on our servers, we observed that
only a few large folios are mapped when reading large files via mmap.
After a thorough analysis, I identified it was caused by the
`/sys/block/*/queue/read_ahead_kb` setting.  On our test servers, this
parameter is set to 128KB.  After I tune it to 2MB, the large folio can
work as expected.  However, I believe the large folio behavior should not
be dependent on the value of read_ahead_kb.  It would be more robust if
the kernel can automatically adopt to it.

With /sys/block/*/queue/read_ahead_kb set to 128KB and performing a
sequential read on a 1GB file using MADV_HUGEPAGE, the differences in
/proc/meminfo are as follows:

- before this patch
  FileHugePages:     18432 kB
  FilePmdMapped:      4096 kB

- after this patch
  FileHugePages:   1067008 kB
  FilePmdMapped:   1048576 kB

This shows that after applying the patch, the entire 1GB file is mapped to
huge pages.  The stable list is CCed, as without this patch, large folios
don't function optimally in the readahead path.

It's worth noting that if read_ahead_kb is set to a larger value that
isn't aligned with huge page sizes (e.g., 4MB + 128KB), it may still fail
to map to hugepages.

Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 4687fdbb805a ("mm/filemap: Support VM_HUGEPAGE for file mappings")
Signed-off-by: Yafang Shao <[email protected]>
Tested-by: kernel test robot <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
mm/readahead.c
This page took 0.0429 seconds and 4 git commands to generate.