]> Git Repo - linux.git/commit
net: stmmac: Apply half-duplex-less constraint for DW QoS Eth only
authorSerge Semin <[email protected]>
Fri, 12 Apr 2024 18:03:14 +0000 (21:03 +0300)
committerPaolo Abeni <[email protected]>
Tue, 16 Apr 2024 13:24:53 +0000 (15:24 +0200)
commit0ebd96f5da4410c0cb8fc75e44f1009530b2f90b
treed1421b44981047a56fc99d28e624cd405ea9951d
parent24f4c99e00354fd79bc1f6cbca9961adbd2dc81e
net: stmmac: Apply half-duplex-less constraint for DW QoS Eth only

There are three DW MAC IP-cores which can have the multiple Tx/Rx queues
enabled:
DW GMAC v3.7+ with AV feature,
DW QoS Eth v4.x/v5.x,
DW XGMAC/XLGMAC
Based on the respective HW databooks, only the DW QoS Eth IP-core doesn't
support the half-duplex link mode in case if more than one queues enabled:

"In multiple queue/channel configurations, for half-duplex operation,
enable only the Q0/CH0 on Tx and Rx. For single queue/channel in
full-duplex operation, any queue/channel can be enabled."

The rest of the IP-cores don't have such constraint. Thus in order to have
the constraint applied for the DW QoS Eth MACs only, let's move the it'
implementation to the respective MAC-capabilities getter and make sure the
getter is called in the queues re-init procedure.

Fixes: b6cfffa7ad92 ("stmmac: fix DMA channel hang in half-duplex mode")
Signed-off-by: Serge Semin <[email protected]>
Reviewed-by: Romain Gantois <[email protected]>
Signed-off-by: Paolo Abeni <[email protected]>
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
This page took 0.051358 seconds and 4 git commands to generate.