]> Git Repo - linux.git/commit
ipv4: avoid undefined behavior in do_ip_setsockopt()
authorXi Wang <[email protected]>
Sun, 11 Nov 2012 11:20:01 +0000 (11:20 +0000)
committerDavid S. Miller <[email protected]>
Sun, 11 Nov 2012 22:53:13 +0000 (17:53 -0500)
commit0c9f79be295c99ac7e4b569ca493d75fdcc19e4e
tree86ac3ac72907079585afc43ec2a25edcb8bb051b
parent77b67063bb6bce6d475e910d3b886a606d0d91f7
ipv4: avoid undefined behavior in do_ip_setsockopt()

(1<<optname) is undefined behavior in C with a negative optname or
optname larger than 31.  In those cases the result of the shift is
not necessarily zero (e.g., on x86).

This patch simplifies the code with a switch statement on optname.
It also allows the compiler to generate better code (e.g., using a
64-bit mask).

Signed-off-by: Xi Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/ipv4/ip_sockglue.c
This page took 0.054971 seconds and 4 git commands to generate.