]> Git Repo - linux.git/commit
net: enetc: stop auto-configuring the port pMAC
authorVladimir Oltean <[email protected]>
Thu, 19 Jan 2023 16:04:31 +0000 (18:04 +0200)
committerDavid S. Miller <[email protected]>
Mon, 23 Jan 2023 13:13:09 +0000 (13:13 +0000)
commit086cc0803550c49c4a802707e40c1878f7c9a469
treee2a4f9622cedc6e41b38bf4397399b7821997726
parent12717decb570ea457b2baa5ad36758c0c967c306
net: enetc: stop auto-configuring the port pMAC

The pMAC (ENETC_PFPMR_PMACE) is probably unconditionally enabled in the
enetc driver to allow RX of preemptible packets and not see them as
error frames. I don't know why TX preemption (ENETC_MMCSR_ME) is enabled
though. With no way to say which traffic classes are preemptible (all
are express by default), no preemptible frames would be transmitted
anyway.

Lastly, it may have been believed that the register write lock-step mode
(now deleted) needed the pMAC to be enabled at all times. I don't know
if that's true. However, I've checked that driver writes to PM1
registers do propagate through to the ENETC IP even when the pMAC is
disabled.

With such incomplete support for frame preemption, it's best to just
remove whatever exists right now and come with something more coherent
later.

Signed-off-by: Vladimir Oltean <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/ethernet/freescale/enetc/enetc_pf.c
This page took 0.053582 seconds and 4 git commands to generate.